feat(Splunk Node): Overhaul #9813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michael-radency
added
node/improvement
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
…splunk-node-overhaul
ShireenMissi
reviewed
Jul 4, 2024
There was a problem hiding this comment.
there is a lot of similarity between the actions code, could be refactored in away to improve code readability and maintainability? Consider abstracting the common functionality into a helper function or class to reduce duplication and make future changes easier.
| }, {}); | ||
| } | ||
|
|
||
| if (splunkObject['s:dict']) { |
There was a problem hiding this comment.
suggestion: avoid using magic strings 's:dict' is used in many places, to enhance maintainability, readability, and reduce the risk of errors, consider defining it as a constant.
| ) { | ||
| const id = this.getNodeParameter(idType, i) as string; | ||
|
|
||
| return id.includes(endpoint) ? id.split(endpoint).pop()! : id; |
There was a problem hiding this comment.
is ! (non null assertion) here necessary?
…splunk-node-overhaul
…splunk-node-overhaul
ShireenMissi
approved these changes
Jul 4, 2024
|
✅ All Cypress E2E specs passed |
3 flaky tests on run #5784 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9813 ↗︎
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
updated/reorganized resources
new operations added
optimizations to request (json instead xml)
added tests
Review / Merge checklist
https://linear.app/n8n/issue/NODE-1395/splunk-node-overhaul