-
Notifications
You must be signed in to change notification settings - Fork 7.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Embeddings Cohere Node): Add v3 Cohere models #9887
Conversation
…English and MultiLang
Hey @KhDu, Thanks for the PR, At a quick glance it looks like you have removed the v2 options which still appear to be valid so this would be a breaking change as the default value is being changed. Instead of replacing v2 can you add more properties and include v3 that way making sure the default remains as v2 to prevent anything unexpected for existing users? The documentation url should also point to our docs not cohere. Did you also run the linter to make sure there were no issues before opening the PR? |
Hey there @Joffcom, I ran linter and got 7 warnings but 0 errors:
|
Just a quick fix. I’m going to send another commit today to clean up and restore it to the source formatting. (It looks like my IDE auto removed comments…etc) |
Done. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this, the change looks good.
Got released with |
Summary
Just a simple PR updating the
EmbeddingsCohere
node to include the latest models for generating text embeddings. It adds new model options (Cohere Embedding V3 English + Multilang...).Changes made:
embed-english-v3.0
,embed-english-light-v3.0
,embed-multilingual-v3.0
,embed-multilingual-light-v3.0
.supplyData
method to use the new models and API format.How to test:
EmbeddingsCohere
node with appropriate credentials.Related Linear tickets, Github issues, and Community forum posts
Review / Merge checklist
release/backport
(if the PR is an urgent fix that needs to be backported)