fix(core): Add a WebCrypto Polyfill for older versions of Node.js 18 #9894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
core
ivov
reviewed
Jul 1, 2024
ivov
previously approved these changes
Jul 1, 2024
ivov
approved these changes
Jul 1, 2024
|
|
3 flaky tests on run #5723 ↗︎
Details:
|
||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| NDV > should not retrieve remote options when required params throw errors |
Screenshots
Video
|
|
| NDV > Stop listening for trigger event from NDV |
Screenshots
Video
|
|
24-ndv-paired-item.cy.ts • 1 flaky test
| Test | Artifacts | |
|---|---|---|
| NDV > resolves expression with default item when input node is not parent, while still pairing items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9894 ↗︎
|
✅ All Cypress E2E specs passed |
netroy
added
the
release/backport
netroy
added a commit
that referenced
this pull request
Jul 1, 2024
netroy
added a commit
that referenced
this pull request
Jul 1, 2024
|
Got released with |
Merged
adrian-martinez-onestic
pushed a commit
to onesdata/n8n-fork
that referenced
this pull request
Jul 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Some older versions of node.js are missing
global.cryptoeven whenrequire('node:crypto').webryptois available.This PR shims the missing global object until we drop support for node.js 18 next year.
Related Linear tickets, Github issues, and Community forum posts
https://community.n8n.io/t/all-workflows-deactivated/49352
#9873
#9884
Review / Merge checklist
release/backport