Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix worker logs relay #9919

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix(core): Fix worker logs relay #9919

merged 2 commits into from
Jul 3, 2024

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Jul 3, 2024

Summary

Recently EventBus was decoupled from InternalHooks via AuditEventRelay, which listens for events and forwards them to be logged. AuditEventRelay works in main but was missing initialization in the worker.

Related Linear tickets, Github issues, and Community forum posts

https://n8nio.slack.com/archives/C069YF49G8Y/p1719923928941329

Review / Merge checklist

  • PR title and summary are descriptive. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.
  • PR Labeled with release/backport (if the PR is an urgent fix that needs to be backported)

@ivov ivov added the release/backport Changes that need to be backported to older releases. label Jul 3, 2024
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Jul 3, 2024
Copy link
Member

@netroy netroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

Copy link

cypress bot commented Jul 3, 2024

2 flaky tests on run #5751 ↗︎

0 399 0 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 ivov 🗃️ e2e/*
Project: n8n Commit: 188fcb589e
Status: Passed Duration: 04:51 💡
Started: Jul 3, 2024 8:24 AM Ended: Jul 3, 2024 8:28 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Screenshots Video
Flakiness  24-ndv-paired-item.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > resolves expression with default item when input node is not parent, while still pairing items Test Replay Screenshots Video

Review all test suite changes for PR #9919 ↗︎

Copy link
Contributor

github-actions bot commented Jul 3, 2024

✅ All Cypress E2E specs passed

@ivov ivov merged commit 7c53433 into master Jul 3, 2024
28 checks passed
@ivov ivov deleted the fix-worker-logs-relay branch July 3, 2024 08:29
cstuncsik pushed a commit that referenced this pull request Jul 3, 2024
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
ivov added a commit that referenced this pull request Jul 3, 2024
@github-actions github-actions bot mentioned this pull request Jul 3, 2024
@janober
Copy link
Member

janober commented Jul 3, 2024

Got released with n8n@1.48.3

@github-actions github-actions bot mentioned this pull request Jul 3, 2024
adrian-martinez-onestic pushed a commit to onesdata/n8n-fork that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team release/backport Changes that need to be backported to older releases. Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants