From 5b10572c2d25135814cc53fe5f9e01ce5a0ac81c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 29 Jul 2024 12:27:00 +0200 Subject: [PATCH 1/3] refactor(core): Display stack trace in error reporter (no-changelog) --- packages/workflow/src/ErrorReporterProxy.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/workflow/src/ErrorReporterProxy.ts b/packages/workflow/src/ErrorReporterProxy.ts index de6c6bec306ca..2eb3e6a7b8bdd 100644 --- a/packages/workflow/src/ErrorReporterProxy.ts +++ b/packages/workflow/src/ErrorReporterProxy.ts @@ -11,7 +11,7 @@ const instance: ErrorReporter = { let e = error; do { const meta = e instanceof ApplicationError ? e.extra : undefined; - Logger.error(`${e.constructor.name}: ${e.message}`, meta); + Logger.error(`${e.constructor.name}: ${e.message}\n${e.stack}`, meta); e = e.cause as Error; } while (e); } From ef5521e062ffe6985a839fb17a796ddcee2ca3b9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 29 Jul 2024 13:13:58 +0200 Subject: [PATCH 2/3] Only in development --- packages/workflow/src/ErrorReporterProxy.ts | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/packages/workflow/src/ErrorReporterProxy.ts b/packages/workflow/src/ErrorReporterProxy.ts index 2eb3e6a7b8bdd..dbe35cd5abc50 100644 --- a/packages/workflow/src/ErrorReporterProxy.ts +++ b/packages/workflow/src/ErrorReporterProxy.ts @@ -5,13 +5,16 @@ interface ErrorReporter { report: (error: Error | string, options?: ReportingOptions) => void; } +const { NODE_ENV } = process.env; +const inDevelopment = !NODE_ENV || NODE_ENV === 'development'; + const instance: ErrorReporter = { report: (error) => { if (error instanceof Error) { let e = error; do { const meta = e instanceof ApplicationError ? e.extra : undefined; - Logger.error(`${e.constructor.name}: ${e.message}\n${e.stack}`, meta); + Logger.error(`${e.constructor.name}: ${e.message}\n${inDevelopment ? e.stack : ''}`, meta); e = e.cause as Error; } while (e); } From 74fa86033036804c95d9325582314f28fc58a94a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Mon, 29 Jul 2024 17:02:53 +0200 Subject: [PATCH 3/3] Apply feedback --- packages/workflow/src/ErrorReporterProxy.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/workflow/src/ErrorReporterProxy.ts b/packages/workflow/src/ErrorReporterProxy.ts index dbe35cd5abc50..b878fcedf0cf5 100644 --- a/packages/workflow/src/ErrorReporterProxy.ts +++ b/packages/workflow/src/ErrorReporterProxy.ts @@ -14,7 +14,8 @@ const instance: ErrorReporter = { let e = error; do { const meta = e instanceof ApplicationError ? e.extra : undefined; - Logger.error(`${e.constructor.name}: ${e.message}\n${inDevelopment ? e.stack : ''}`, meta); + if (inDevelopment) console.log(e, meta); + else Logger.error(`${e.constructor.name}: ${e.message}`, meta); e = e.cause as Error; } while (e); }