From 81447e84683ca870e0d393d1e0363394a1c89ada Mon Sep 17 00:00:00 2001 From: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Date: Fri, 16 Aug 2024 10:30:28 -0500 Subject: [PATCH 1/3] Remove displayOptions from child parameter --- .../nodes/InvoiceNinja/PaymentDescription.ts | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+) diff --git a/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts b/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts index 17ae0938e99c5..1ae6581bf05ad 100644 --- a/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts +++ b/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts @@ -85,6 +85,7 @@ export const paymentFields: INodeProperties[] = [ default: {}, displayOptions: { show: { + apiVersion: ['v4'], operation: ['create'], resource: ['payment'], }, @@ -231,6 +232,34 @@ export const paymentFields: INodeProperties[] = [ ], default: 1, }, + { + displayName: 'Transfer Reference', + name: 'transferReference', + type: 'string', + default: '', + }, + { + displayName: 'Private Notes', + name: 'privateNotes', + type: 'string', + default: '', + }, + ], + }, + { + displayName: 'Additional Fields', + name: 'additionalFields', + type: 'collection', + placeholder: 'Add Field', + default: {}, + displayOptions: { + show: { + apiVersion: ['v5'], + operation: ['create'], + resource: ['payment'], + }, + }, + options: [ { displayName: 'Payment Type', name: 'paymentType', From 35b5b51b65c747095531f58dfec670e0dcab5195 Mon Sep 17 00:00:00 2001 From: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Date: Fri, 16 Aug 2024 10:43:47 -0500 Subject: [PATCH 2/3] Remove display options from child parameter --- .../nodes/InvoiceNinja/PaymentDescription.ts | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts b/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts index 1ae6581bf05ad..82680ef85ec6e 100644 --- a/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts +++ b/packages/nodes-base/nodes/InvoiceNinja/PaymentDescription.ts @@ -95,11 +95,6 @@ export const paymentFields: INodeProperties[] = [ displayName: 'Payment Type', name: 'paymentType', type: 'options', - displayOptions: { - show: { - apiVersion: ['v4'], - }, - }, options: [ { name: 'ACH', @@ -264,11 +259,6 @@ export const paymentFields: INodeProperties[] = [ displayName: 'Payment Type', name: 'paymentType', type: 'options', - displayOptions: { - show: { - apiVersion: ['v5'], - }, - }, options: [ { name: 'Bank Transfer', From 1c6b9bc5c7c05503a1ec6b5d4cd93da4b9efe300 Mon Sep 17 00:00:00 2001 From: CodeShakingSheep <19874562+CodeShakingSheep@users.noreply.github.com> Date: Fri, 16 Aug 2024 12:37:36 -0500 Subject: [PATCH 3/3] Remove display options from Create Exepense - Additional fields --- .../nodes/InvoiceNinja/ExpenseDescription.ts | 138 ++++++++++++++++-- 1 file changed, 128 insertions(+), 10 deletions(-) diff --git a/packages/nodes-base/nodes/InvoiceNinja/ExpenseDescription.ts b/packages/nodes-base/nodes/InvoiceNinja/ExpenseDescription.ts index 729c6a8b77a4b..a53d0e271e809 100644 --- a/packages/nodes-base/nodes/InvoiceNinja/ExpenseDescription.ts +++ b/packages/nodes-base/nodes/InvoiceNinja/ExpenseDescription.ts @@ -53,6 +53,7 @@ export const expenseFields: INodeProperties[] = [ default: {}, displayOptions: { show: { + apiVersion: ['v4'], operation: ['create'], resource: ['expense'], }, @@ -120,11 +121,6 @@ export const expenseFields: INodeProperties[] = [ displayName: 'Payment Type', name: 'paymentType', type: 'options', - displayOptions: { - show: { - apiVersion: ['v4'], - }, - }, options: [ { name: 'ACH', @@ -257,15 +253,137 @@ export const expenseFields: INodeProperties[] = [ ], default: 1, }, + { + displayName: 'Private Notes', + name: 'privateNotes', + type: 'string', + default: '', + }, + { + displayName: 'Public Notes', + name: 'publicNotes', + type: 'string', + default: '', + }, + { + displayName: 'Tax Name 1', + name: 'taxName1', + type: 'string', + default: '', + }, + { + displayName: 'Tax Name 2', + name: 'taxName2', + type: 'string', + default: '', + }, + { + displayName: 'Tax Rate 1', + name: 'taxRate1', + type: 'number', + default: 0, + }, + { + displayName: 'Tax Rate 2', + name: 'taxRate2', + type: 'number', + default: 0, + }, + { + displayName: 'Transaction Reference', + name: 'transactionReference', + type: 'string', + default: '', + }, + { + displayName: 'Vendor Name or ID', + name: 'vendor', + type: 'options', + description: + 'Choose from the list, or specify an ID using an expression', + typeOptions: { + loadOptionsMethod: 'getVendors', + }, + default: '', + }, + ], + }, + { + displayName: 'Additional Fields', + name: 'additionalFields', + type: 'collection', + placeholder: 'Add Field', + default: {}, + displayOptions: { + show: { + apiVersion: ['v5'], + operation: ['create'], + resource: ['expense'], + }, + }, + options: [ + { + displayName: 'Amount', + name: 'amount', + type: 'number', + default: 0, + }, + { + displayName: 'Billable', + name: 'billable', + type: 'boolean', + default: false, + }, + { + displayName: 'Client Name or ID', + name: 'client', + type: 'options', + description: + 'Choose from the list, or specify an ID using an expression', + typeOptions: { + loadOptionsMethod: 'getClients', + }, + default: '', + }, + { + displayName: 'Custom Value 1', + name: 'customValue1', + type: 'string', + default: '', + }, + { + displayName: 'Custom Value 2', + name: 'customValue2', + type: 'string', + default: '', + }, + { + displayName: 'Category Name or ID', + name: 'category', + type: 'options', + description: + 'Choose from the list, or specify an ID using an expression', + typeOptions: { + loadOptionsMethod: 'getExpenseCategories', + }, + default: '', + }, + { + displayName: 'Expense Date', + name: 'expenseDate', + type: 'dateTime', + default: '', + }, + { + displayName: 'Payment Date', + name: 'paymentDate', + type: 'dateTime', + default: '', + }, { displayName: 'Payment Type', name: 'paymentType', type: 'options', - displayOptions: { - show: { - apiVersion: ['v5'], - }, - }, options: [ { name: 'Bank Transfer',