From b2831ba4fc5bb71f050894be30d2c650c97a46d3 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E0=A4=95=E0=A4=BE=E0=A4=B0=E0=A4=A4=E0=A5=8B=E0=A4=AB?= =?UTF-8?q?=E0=A5=8D=E0=A4=AB=E0=A5=87=E0=A4=B2=E0=A4=B8=E0=A5=8D=E0=A4=95?= =?UTF-8?q?=E0=A5=8D=E0=A4=B0=E0=A4=BF=E0=A4=AA=E0=A5=8D=E0=A4=9F=E2=84=A2?= Date: Mon, 26 Aug 2024 14:12:32 +0200 Subject: [PATCH] revert(core): Stop explicit redis client disconnect on shutdown --- .../cli/src/services/redis/redis-client.service.ts | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/packages/cli/src/services/redis/redis-client.service.ts b/packages/cli/src/services/redis/redis-client.service.ts index bf70d8114d37e..822392708631b 100644 --- a/packages/cli/src/services/redis/redis-client.service.ts +++ b/packages/cli/src/services/redis/redis-client.service.ts @@ -2,12 +2,10 @@ import { Service } from 'typedi'; import { Logger } from '@/logger'; import ioRedis from 'ioredis'; import type { Cluster, RedisOptions } from 'ioredis'; -import type { RedisClientType } from './redis.types'; - -import { OnShutdown } from '@/decorators/on-shutdown'; -import { LOWEST_SHUTDOWN_PRIORITY } from '@/constants'; import { GlobalConfig } from '@n8n/config'; +import type { RedisClientType } from './redis.types'; + @Service() export class RedisClientService { private readonly clients = new Set(); @@ -28,13 +26,6 @@ export class RedisClientService { return client; } - @OnShutdown(LOWEST_SHUTDOWN_PRIORITY) - disconnectClients() { - for (const client of this.clients) { - client.disconnect(); - } - } - /** * Ensure prefix is wrapped in curly braces for Redis cluster. * See: https://github.com/OptimalBits/bull/blob/develop/PATTERNS.md