From 502465cab5294bd49b6f14e45bfeaf33478f32aa Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 30 Sep 2022 12:23:01 +0200 Subject: [PATCH 1/2] :zap: Sort CI steps by length --- .github/workflows/ci-master.yml | 8 ++++---- .github/workflows/ci-pull-requests.yml | 12 ++++++------ 2 files changed, 10 insertions(+), 10 deletions(-) diff --git a/.github/workflows/ci-master.yml b/.github/workflows/ci-master.yml index f340184a82bc1..89b040e07c65f 100644 --- a/.github/workflows/ci-master.yml +++ b/.github/workflows/ci-master.yml @@ -27,11 +27,11 @@ jobs: - name: Install npm and dependencies run: npm install -g npm@latest && npm install - - name: Build - run: npm run build --if-present + - name: Lint + run: npm run lint - name: Test run: npm run test - - name: Lint - run: npm run lint + - name: Build + run: npm run build --if-present diff --git a/.github/workflows/ci-pull-requests.yml b/.github/workflows/ci-pull-requests.yml index 3be4f949fafaf..823b77fc914ad 100644 --- a/.github/workflows/ci-pull-requests.yml +++ b/.github/workflows/ci-pull-requests.yml @@ -24,12 +24,6 @@ jobs: - name: Install npm and dependencies run: npm install -g npm@latest && npm install - - name: Build - run: npm run build --if-present - - - name: Test - run: npm run test - - name: Fetch base branch for `git diff` run: git fetch origin ${{ github.event.pull_request.base.ref }}:${{ github.event.pull_request.base.ref }} @@ -37,3 +31,9 @@ jobs: env: ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }} run: npm run lint + + - name: Test + run: npm run test + + - name: Build + run: npm run build --if-present From 15e541066813ccee4fa1758e0153cd60c264a5b0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Iv=C3=A1n=20Ovejero?= Date: Fri, 30 Sep 2022 12:29:05 +0200 Subject: [PATCH 2/2] :bug: `Build` before `test` for n8n packages --- .github/workflows/ci-master.yml | 6 +++--- .github/workflows/ci-pull-requests.yml | 6 +++--- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/ci-master.yml b/.github/workflows/ci-master.yml index 89b040e07c65f..d1da655d9d386 100644 --- a/.github/workflows/ci-master.yml +++ b/.github/workflows/ci-master.yml @@ -30,8 +30,8 @@ jobs: - name: Lint run: npm run lint - - name: Test - run: npm run test - - name: Build run: npm run build --if-present + + - name: Test + run: npm run test diff --git a/.github/workflows/ci-pull-requests.yml b/.github/workflows/ci-pull-requests.yml index 823b77fc914ad..e44c25c0d7b50 100644 --- a/.github/workflows/ci-pull-requests.yml +++ b/.github/workflows/ci-pull-requests.yml @@ -32,8 +32,8 @@ jobs: ESLINT_PLUGIN_DIFF_COMMIT: ${{ github.event.pull_request.base.ref }} run: npm run lint - - name: Test - run: npm run test - - name: Build run: npm run build --if-present + + - name: Test + run: npm run test