From d986ca72daa8cf34bcff1ef0d96bde94300237a1 Mon Sep 17 00:00:00 2001 From: Csaba Tuncsik Date: Fri, 18 Nov 2022 17:49:43 +0100 Subject: [PATCH 1/4] fix(editor): Table view column limit tooltip --- packages/editor-ui/src/components/RunDataTable.vue | 8 ++++++-- packages/editor-ui/src/plugins/i18n/locales/en.json | 4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/packages/editor-ui/src/components/RunDataTable.vue b/packages/editor-ui/src/components/RunDataTable.vue index 771972c15e4b0..609121d02a48e 100644 --- a/packages/editor-ui/src/components/RunDataTable.vue +++ b/packages/editor-ui/src/components/RunDataTable.vue @@ -73,7 +73,10 @@ @@ -169,7 +172,7 @@ import { mapStores } from 'pinia'; import { useWorkflowsStore } from '@/stores/workflows'; import { useNDVStore } from '@/stores/ndv'; -const MAX_COLUMNS_LIMIT = 40; +const MAX_COLUMNS_LIMIT = 2; export default mixins(externalHooks).extend({ name: 'run-data-table', @@ -212,6 +215,7 @@ export default mixins(externalHooks).extend({ hoveringPath: null as null | string, mappingHintVisible: false, activeRow: null as number | null, + columnLimit: MAX_COLUMNS_LIMIT, columnLimitExceeded: false, }; }, diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index 445402cf634f0..8900502d9c72f 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -364,8 +364,8 @@ "dataMapping.jsonHint": " Drag a JSON key onto {name} to map data", "dataMapping.mapKeyToField": "Map '{name}' to a field", "dataMapping.mapAllKeysToField": "Map every '{name}' to a field", - "dataMapping.tableView.tableColumnsExceeded": "Some columns are hidden.", - "dataMapping.tableView.tableColumnsExceeded.tooltip": "Your data has more than {columnLimit} columns so some are hidden. Switch to {0} to see all data.", + "dataMapping.tableView.tableColumnsExceeded": "Some columns are hidden", + "dataMapping.tableView.tableColumnsExceeded.tooltip": "Your data has more than {columnLimit} columns so some are hidden. Switch to {link} to see all data.", "dataMapping.tableView.tableColumnsExceeded.tooltip.link": "JSON view", "displayWithChange.cancelEdit": "Cancel Edit", "displayWithChange.clickToChange": "Click to Change", From 4ce2d1f0c039a9459fb32d5f672aa603101ccb98 Mon Sep 17 00:00:00 2001 From: Csaba Tuncsik Date: Fri, 18 Nov 2022 18:04:02 +0100 Subject: [PATCH 2/4] fix(editor): lint fix --- .../src/components/ResourceLocator/ResourceLocator.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor-ui/src/components/ResourceLocator/ResourceLocator.vue b/packages/editor-ui/src/components/ResourceLocator/ResourceLocator.vue index d20b97e63edd7..da680353e36b5 100644 --- a/packages/editor-ui/src/components/ResourceLocator/ResourceLocator.vue +++ b/packages/editor-ui/src/components/ResourceLocator/ResourceLocator.vue @@ -69,7 +69,7 @@ :stickyOffset="4" @drop="onDrop" > -