From 11da3b24d076d54f07bf7c6d0675dd0f2d9d5c19 Mon Sep 17 00:00:00 2001 From: Omar Ajoue Date: Wed, 10 Jan 2024 12:46:47 +0000 Subject: [PATCH 1/2] fix: Store workflow settings when saving an execution --- .../cli/src/databases/repositories/execution.repository.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/databases/repositories/execution.repository.ts b/packages/cli/src/databases/repositories/execution.repository.ts index 89b032ab065ae..32ddc25f65b59 100644 --- a/packages/cli/src/databases/repositories/execution.repository.ts +++ b/packages/cli/src/databases/repositories/execution.repository.ts @@ -226,10 +226,10 @@ export class ExecutionRepository extends Repository { const { data, workflowData, ...rest } = execution; const { identifiers: inserted } = await this.insert(rest); const { id: executionId } = inserted[0] as { id: string }; - const { connections, nodes, name } = workflowData ?? {}; + const { connections, nodes, name, settings } = workflowData ?? {}; await this.executionDataRepository.insert({ executionId, - workflowData: { connections, nodes, name, id: workflowData?.id }, + workflowData: { connections, nodes, name, settings, id: workflowData?.id }, data: stringify(data), }); return String(executionId); From a6f8a4f7546f5aecde305dc114f9335691069eab Mon Sep 17 00:00:00 2001 From: Omar Ajoue Date: Wed, 10 Jan 2024 12:54:06 +0000 Subject: [PATCH 2/2] fix: Store workflow settings when creating a new execution --- .../database/repositories/execution.repository.test.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/cli/test/integration/database/repositories/execution.repository.test.ts b/packages/cli/test/integration/database/repositories/execution.repository.test.ts index 72ebaa95969b5..cfb897d627a56 100644 --- a/packages/cli/test/integration/database/repositories/execution.repository.test.ts +++ b/packages/cli/test/integration/database/repositories/execution.repository.test.ts @@ -20,7 +20,7 @@ describe('ExecutionRepository', () => { describe('createNewExecution', () => { it('should save execution data', async () => { const executionRepo = Container.get(ExecutionRepository); - const workflow = await createWorkflow(); + const workflow = await createWorkflow({ settings: { executionOrder: 'v1' } }); const executionId = await executionRepo.createNewExecution({ workflowId: workflow.id, data: { @@ -48,6 +48,7 @@ describe('ExecutionRepository', () => { connections: workflow.connections, nodes: workflow.nodes, name: workflow.name, + settings: workflow.settings, }); expect(executionData?.data).toEqual('[{"resultData":"1"},{}]'); });