From 3569c8e3387b843210a011ca7fd1091cad3ea185 Mon Sep 17 00:00:00 2001 From: Deborah Barnard Date: Wed, 17 Jan 2024 11:47:22 +0000 Subject: [PATCH 1/3] suggested UI text changes for switch node and other filters --- packages/editor-ui/src/plugins/i18n/locales/en.json | 12 ++++++------ packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts | 2 +- .../descriptions/filter.description.ts | 4 ++-- 3 files changed, 9 insertions(+), 9 deletions(-) diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index af5cbe9c4b270..d4be35b69c2dc 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -2340,20 +2340,20 @@ "filter.operator.notRegex": "does not match regex", "filter.operator.gt": "is greater than", "filter.operator.lt": "is less than", - "filter.operator.gte": "is greater than or equal", - "filter.operator.lte": "is less than or equal", + "filter.operator.gte": "is greater than or equal to", + "filter.operator.lte": "is less than or equal it", "filter.operator.after": "is after", "filter.operator.before": "is before", - "filter.operator.afterOrEquals": "is after or equal", - "filter.operator.beforeOrEquals": "is before or equal", + "filter.operator.afterOrEquals": "is after or equal to", + "filter.operator.beforeOrEquals": "is before or equal to", "filter.operator.true": "is true", "filter.operator.false": "is false", "filter.operator.lengthEquals": "length equal to", "filter.operator.lengthNotEquals": "length not equal to", "filter.operator.lengthGt": "length greater than", "filter.operator.lengthLt": "length less than", - "filter.operator.lengthGte": "length greater than or equal", - "filter.operator.lengthLte": "length less than or equal", + "filter.operator.lengthGte": "length greater than or equal to", + "filter.operator.lengthLte": "length less than or equal to", "filter.operator.empty": "is empty", "filter.operator.notEmpty": "is not empty", "filter.combinator.or": "OR", diff --git a/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts b/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts index 52e4864433d60..477da80fae0d4 100644 --- a/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts +++ b/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts @@ -100,7 +100,7 @@ export class SwitchV3 implements INodeType { // eslint-disable-next-line n8n-nodes-base/node-param-default-wrong-for-number default: '={{}}', description: - "The output's index to which send an input item, use expressions to calculate what input item should be routed to which output, expression must return a number", + "The output index to send the input item to. Use an expression to calculate which input item should be routed to which output. The expression must return a number.", }, { displayName: 'Routing Rules', diff --git a/packages/nodes-base/nodes/TheHiveProject/descriptions/filter.description.ts b/packages/nodes-base/nodes/TheHiveProject/descriptions/filter.description.ts index c1660f7a4a8c0..015d766e8885b 100644 --- a/packages/nodes-base/nodes/TheHiveProject/descriptions/filter.description.ts +++ b/packages/nodes-base/nodes/TheHiveProject/descriptions/filter.description.ts @@ -193,7 +193,7 @@ export const genericFiltersCollection: INodeProperties = { description: 'Field is greater than value', }, { - name: 'Greater Than Or Equal', + name: 'Greater Than Or Equal To', value: '_gte', description: 'Field is greater than or equal to value', }, @@ -208,7 +208,7 @@ export const genericFiltersCollection: INodeProperties = { description: 'Field is less than value', }, { - name: 'Less Than Or Equal', + name: 'Less Than Or Equal To', value: '_lte', description: 'Field is less than or equal to value', }, From 9981bf93588c48842f6313b9a0d8cf561dcf3b83 Mon Sep 17 00:00:00 2001 From: Deborah Date: Wed, 17 Jan 2024 11:54:04 +0000 Subject: [PATCH 2/3] Update packages/editor-ui/src/plugins/i18n/locales/en.json --- packages/editor-ui/src/plugins/i18n/locales/en.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/editor-ui/src/plugins/i18n/locales/en.json b/packages/editor-ui/src/plugins/i18n/locales/en.json index d4be35b69c2dc..9ff9d2e1cbc7f 100644 --- a/packages/editor-ui/src/plugins/i18n/locales/en.json +++ b/packages/editor-ui/src/plugins/i18n/locales/en.json @@ -2341,7 +2341,7 @@ "filter.operator.gt": "is greater than", "filter.operator.lt": "is less than", "filter.operator.gte": "is greater than or equal to", - "filter.operator.lte": "is less than or equal it", + "filter.operator.lte": "is less than or equal to", "filter.operator.after": "is after", "filter.operator.before": "is before", "filter.operator.afterOrEquals": "is after or equal to", From fe141e26fd5d50083290f685f58f81c18e1842b8 Mon Sep 17 00:00:00 2001 From: Deborah Barnard Date: Wed, 17 Jan 2024 12:07:35 +0000 Subject: [PATCH 3/3] fix lint issue --- packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts b/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts index 477da80fae0d4..eceefdd79747b 100644 --- a/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts +++ b/packages/nodes-base/nodes/Switch/V3/SwitchV3.node.ts @@ -100,7 +100,7 @@ export class SwitchV3 implements INodeType { // eslint-disable-next-line n8n-nodes-base/node-param-default-wrong-for-number default: '={{}}', description: - "The output index to send the input item to. Use an expression to calculate which input item should be routed to which output. The expression must return a number.", + 'The output index to send the input item to. Use an expression to calculate which input item should be routed to which output. The expression must return a number.', }, { displayName: 'Routing Rules',