From 2d680cf649795f5aa7cc1a58fb4fb4e5aa30c9c4 Mon Sep 17 00:00:00 2001 From: Tomi Turtiainen <10324676+tomi@users.noreply.github.com> Date: Thu, 18 Jan 2024 11:18:54 +0200 Subject: [PATCH] fix: Force posthog recording to be disabled outside cloud The recordings are not enabled by default, but env variable enabled opt-in. This changes the logic that opt-in requires cloud deployment. --- packages/cli/src/config/schema.ts | 6 ------ packages/cli/src/services/frontend.service.ts | 4 +--- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/packages/cli/src/config/schema.ts b/packages/cli/src/config/schema.ts index 3a2c3a8ee4842..fca700fc7890d 100644 --- a/packages/cli/src/config/schema.ts +++ b/packages/cli/src/config/schema.ts @@ -1143,12 +1143,6 @@ export const schema = { default: 'https://ph.n8n.io', env: 'N8N_DIAGNOSTICS_POSTHOG_API_HOST', }, - disableSessionRecording: { - doc: 'Disable posthog session recording', - format: Boolean, - default: true, - env: 'N8N_DIAGNOSTICS_POSTHOG_DISABLE_RECORDING', - }, }, sentry: { dsn: { diff --git a/packages/cli/src/services/frontend.service.ts b/packages/cli/src/services/frontend.service.ts index 7849884d1a5b1..8e815c9d2ada6 100644 --- a/packages/cli/src/services/frontend.service.ts +++ b/packages/cli/src/services/frontend.service.ts @@ -115,9 +115,7 @@ export class FrontendService { apiHost: config.getEnv('diagnostics.config.posthog.apiHost'), apiKey: config.getEnv('diagnostics.config.posthog.apiKey'), autocapture: false, - disableSessionRecording: config.getEnv( - 'diagnostics.config.posthog.disableSessionRecording', - ), + disableSessionRecording: config.getEnv('deployment.type') !== 'cloud', debug: config.getEnv('logs.level') === 'debug', }, personalizationSurveyEnabled: