Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break our new instantiations from method calls #125

Closed
n8rzz opened this issue Nov 20, 2016 · 0 comments
Closed

Break our new instantiations from method calls #125

n8rzz opened this issue Nov 20, 2016 · 0 comments
Assignees
@n8rzz
Labels
refactor
Milestone
v3.2.0

Comments

@n8rzz
Copy link
Owner

n8rzz commented Nov 20, 2016 •
edited
Loading

Sprinkled through the fms, there are method calls where one of the arguments is an instantiation of a class. These instantiations should be set to a constant and that constant should be passed as the argument.

this can be abstracted further as part of #120.
@n8rzz n8rzz added the refactor label Nov 20, 2016
@n8rzz n8rzz added this to the v3.2.0 milestone Nov 20, 2016
@n8rzz n8rzz self-assigned this Nov 22, 2016
@n8rzz n8rzz mentioned this issue Nov 22, 2016
Merged
@n8rzz n8rzz closed this as completed Nov 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@n8rzz n8rzz

Labels
refactor
Projects
None yet
Milestone
v3.2.0
Development

No branches or pull requests
1 participant
@n8rzz