Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abstract position calculation from PositionModel to helper function #159

Closed
7 tasks done
n8rzz opened this issue Nov 25, 2016 · 0 comments
Closed
7 tasks done

Abstract position calculation from PositionModel to helper function #159

n8rzz opened this issue Nov 25, 2016 · 0 comments
Assignees
Labels
Milestone

Comments

@n8rzz
Copy link
Owner

n8rzz commented Nov 25, 2016

There are many spots within the app that use the PositionModel just to obtain coordinates. If the method for calculating those coordinates were abstracted, we could skip the step of creating a model and get right to the data we actually need.

  • move positon to a getter
  • move gps to a getter
  • abstract .distantceToPoint()
  • add tests for .distantceToPoint()
  • abstract position -> coordinate calculations
  • add tests for newly abstracted function
  • update implementations of PositionModels that are using only the coordinates to use new function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant