Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instances of prop to use this #43

Closed
n8rzz opened this issue Oct 21, 2016 · 3 comments
Closed

Update instances of prop to use this #43

n8rzz opened this issue Oct 21, 2016 · 3 comments

Comments

@n8rzz
Copy link
Owner

n8rzz commented Oct 21, 2016

Update direct usages of prop inside classes. Instead of a class setting class properties to prop use this.

However, for now, we must maintain the references to the original prop values so we don't break everything.

the current workaround is:

const aircraft = {};

export default class Aircraft {
    constructor() {
        this.aircraft = aircraft;
        prop.aircraft = aircraft;
    }

This way we can maintain the original props, but still use class properties in the usual way.


There are also references to prop values from other classes sprinkled throughout, those are not being refactored [yet] with this issue.

@n8rzz n8rzz added the refactor label Oct 21, 2016
@n8rzz n8rzz added this to the v3.0.0 milestone Oct 21, 2016
@n8rzz n8rzz self-assigned this Oct 21, 2016
@n8rzz n8rzz added the WIP label Oct 31, 2016
@n8rzz n8rzz modified the milestones: v3.0.x, v3.0.0 Oct 31, 2016
@n8rzz n8rzz removed the WIP label Nov 7, 2016
@n8rzz
Copy link
Owner Author

n8rzz commented Nov 7, 2016

work started on branch feature/ATC-43

@n8rzz
Copy link
Owner Author

n8rzz commented Nov 19, 2016

gameController updated with #96

@erikquinn
Copy link
Collaborator

This issue was moved to openscope/openscope#62

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants