Replace references to "icao" with "id" where appropriate

[erikquinn]

There are some scattered places where "icao" is used to mean "id", and doesn't really make sense. A quick sweep should be done to rename these.

[n8rzz]

would 'identifier' be an appropriate word here, or aircraftId? Better question; when would icao be appropriate?

I would like to reserve the use of id to be used only as a literal id of a class instance.

[erikquinn]

Yeah, sorry I didn't mean id necessarily would be the name. But icao makes sense for:

• ICAO's aircraft type designators (B738, A321, A343, SF34)
• ICAO's airport designators (KIAD, EGLL, ZSPD, EIDW, LXGB, GMMC)

And that's it, really. It's helpful to use icao as a property when there are multiple possible designators under ICAO's listings as opposed to IATA's. For example, my home airport is {icao: 'KIAD', iata: 'IAD'}, Dublin is {icao: 'EIDW', iata: 'DUB'}, etc.

Other than cases like these, any generalized property name would be appropriate.

[n8rzz]

awesome, that makes it much clearer. thanks!

[erikquinn]

This issue was moved to openscope/openscope#69