-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Python 3 #47
Comments
Interesting. As mentioned in the other issue, Travis CI has no problems running all this on Python 3.6. I'm wondering why this isn't working for you locally. |
Yeah, I noticed the build runs fine after I created this ticket. Investigating futher, I noticed the default python3 on the remote host is python 3.5 (ubuntu xenial). Changing to 3.7 made no difference. Using 2.7 does work, though. (changed with It fails on the
|
It's been a hot second since I last Python'd, does |
Yeah, I fixed that one but then I just took a quick look at the |
Tests run on the host. If you'd like, you can PR in changes to Travis which will run the tests on 2.7, 3.4, 3.5, 3.6, and if Travis supports it yet, 3.7. Build times will increase, but this should give better coverage across Python versions. |
I actually have a better solution to this on my local
There is also a bug in the json parsing fixed by adding encoding
|
There are several errors related bytes/str when running the role with Python3.
w
fails - usewb
self.fail
call fails onstdout.split
linep.communicate
call fails due tojson.dumps
outputtingstr
notbytes
Fixing all 3 above still gave me errors and I can't proceed on this right now, but I'll try to come up with a PR this week.
The text was updated successfully, but these errors were encountered: