Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error with Angular > 11.0.2 #7

Closed
whyboris opened this issue Mar 16, 2021 · 5 comments · Fixed by #11
Closed

Error with Angular > 11.0.2 #7

whyboris opened this issue Mar 16, 2021 · 5 comments · Fixed by #11

Comments

@whyboris
Copy link
Contributor

npm 7 seems to be more strict with dependency resolution and provides the following error when "@angular/common": "11.2.1" is installed:

npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@">= 6.0.0 < 11.0.2" from an-qrcode@1.0.7
npm ERR! node_modules/an-qrcode
npm ERR!   an-qrcode@"1.0.7" from the root project

A simple solution is probably to bump the https://github.com/naimmalek/an-qrcode/blob/master/package.json#L15 version 🤔

@whyboris
Copy link
Contributor Author

@naimmalek - would you accept a PR that bumps the versions, and would you then be able to create a new release that supports angular 12? 😃

@whyboris whyboris mentioned this issue Feb 13, 2022
@whyboris
Copy link
Contributor Author

Took a while for me to stumble across this again 😅
@naimmalek - could you glance at and merge the #11 PR if you think it will be an improvement, and especially if it solves this Issue 🤞

@whyboris
Copy link
Contributor Author

I just updated my PR to include all newest dependency versions as of December 2022 😎 #11 which includes Angular 15 🥳

@whyboris
Copy link
Contributor Author

whyboris commented Aug 9, 2023

I'd be thrilled to update to Angular 16 as well -- if we could merge it in 🙇 @naimmalek 🙇 please 😊
Probably best to merge in #11 first, close out all the dependabot PRs, and I'll make 16 work too 🤝

@whyboris
Copy link
Contributor Author

Looks like everything works with angular 17 once this PR is merged 🤞

#11 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant