From 5ecec4aca02af779999ce1a596e8c8c0e4967281 Mon Sep 17 00:00:00 2001 From: Masato Naka Date: Sun, 21 Aug 2022 21:38:03 +0900 Subject: [PATCH] fix lint error: Update is not checked (errcheck) --- controllers/mysqluser_controller.go | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/controllers/mysqluser_controller.go b/controllers/mysqluser_controller.go index 33cb4c15..239dfdab 100644 --- a/controllers/mysqluser_controller.go +++ b/controllers/mysqluser_controller.go @@ -95,7 +95,9 @@ func (r *MySQLUserReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( log.Error(err, "[FetchMySQL] Failed") mysqlUser.Status.Phase = mysqlUserPhaseNotReady mysqlUser.Status.Reason = mysqlUserReasonMySQLFetchFailed - r.Status().Update(ctx, mysqlUser) + if serr := r.Status().Update(ctx, mysqlUser); serr != nil { + log.Error(serr, "Failed to update mysqluser status", "mysqlUser", mysqlUser.Name) + } return ctrl.Result{}, client.IgnoreNotFound(err) } log.Info("[FetchMySQL] Found") @@ -122,7 +124,9 @@ func (r *MySQLUserReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( if err != nil { mysqlUser.Status.Phase = mysqlUserPhaseNotReady mysqlUser.Status.Reason = mysqlUserReasonMySQLConnectionFailed - r.Status().Update(ctx, mysqlUser) + if serr := r.Status().Update(ctx, mysqlUser); serr != nil { + log.Error(serr, "Failed to update mysqluser status", "mysqlUser", mysqlUser.Name) + } log.Error(err, "[MySQLClient] Failed to create") return ctrl.Result{}, err // requeue } @@ -132,7 +136,9 @@ func (r *MySQLUserReconciler) Reconcile(ctx context.Context, req ctrl.Request) ( mysqlUser.Status.Phase = mysqlUserPhaseNotReady mysqlUser.Status.Reason = mysqlUserReasonMySQLConnectionFailed log.Error(err, "[MySQLClient] Failed to connect to MySQL", "mysqlName", mysqlName) - r.Status().Update(ctx, mysqlUser) + if serr := r.Status().Update(ctx, mysqlUser); serr != nil { + log.Error(serr, "Failed to update mysqluser status", "mysqlUser", mysqlUser.Name) + } return ctrl.Result{}, err // requeue } log.Info("[MySQLClient] Successfully connected")