Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop privileges when executing programs as needed #39

Open
JeremyRand opened this issue Apr 14, 2018 · 1 comment
Open

Drop privileges when executing programs as needed #39

JeremyRand opened this issue Apr 14, 2018 · 1 comment

Comments

@JeremyRand
Copy link
Member

The chainloader for the Namecoin Core and Dnssec-Trigger installers isn't dropping its Administrator privileges before launching the installers. This seems to be causing a variety of unfortunate behavior, including a symptom where Namecoin Core's installer thinks that its AppData folder is located in ProgramData (which then causes permission errors the next time Namecoin Core is launched from the start menu, even after you later uninstall and reinstall Namecoin Core). And of course it's also bad from a security point of view.

Bitcoin Core actually has the same issue in their NSIS script (when it launches bitcoin-qt.exe at the end). I just submitted a PR to Bitcoin Core to fix that issue; if it passes peer review I'll adapt it for ncdns-nsis and submit a PR here as well.

@JeremyRand
Copy link
Member Author

The symptoms that were believed to be caused by this issue were actually fixed by #42 . We should still check whether we're executing anything with unnecessary privileges, though.

@JeremyRand JeremyRand changed the title Installer chainloader should drop privileges Drop privileges when executing programs as needed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant