info: Add utc_offset info for external usage #1923
Conversation
|
This patch is to make the UTC time adjustment easier than https://youtu.be/KtVdeHfD45o?si=hIMvE10XI87XqXIW. |
|
The remaing job is to make this feature doesn't break previously recorded data to support backward compatibility. |
honggyukim
force-pushed
the
check/utc-offset
branch
from
bb6c724 to
f0e4d6c
Compare
cmds/info.c
Outdated
| if (info_mask & UTC_OFFSET) | ||
| process(data, fmt, "utc offset", info->utc_offset); |
There was a problem hiding this comment.
I think the info->utc_offset is for internal information so better not to be printed in uftrace info output.
There was a problem hiding this comment.
It's now removed after another update.
honggyukim
force-pushed
the
check/utc-offset
branch
3 times, most recently
from
5d83c87 to
d74c7d2
Compare
|
I just fixed @namhyung @MatthewKhouzam I think it's good to be merged now. Please have a look. |
cmds/info.c
Outdated
| /* calculate time offset between UTC and clock_source. */ | ||
| offset = difftime(current_time, ts.tv_sec); | ||
|
|
||
| dprintf(fha->fd, "utc_offset:%ld\n", (time_t)offset); |
There was a problem hiding this comment.
For %ld, you'd better cast it to unsigned long.
There was a problem hiding this comment.
As I understand, time_t is long type so %ld is used instead of %lu.
# 143 "/usr/include/x86_64-linux-gnu/bits/types.h" 2 3 4
...
typedef long int __time_t;
...
typedef __time_t time_t;Since this offset is used to adjust the other time_t value for UTC time, I made it casted to the same type time_t. Should I change it to unsigned long and print it with %lu instead?
There was a problem hiding this comment.
Oh, sorry. I meant long. But it could be different on different architecture or distro. So I think it's better to explicitly cast to long instead of time_t.
There was a problem hiding this comment.
OK. I've just changed it to use long for offset type itself.
In some cases, there is a requirement to get the time offset between UTC time and our timestamp from the given clock source, CLOCK_MONOTONIC by default. This patch provides an additional info to provide UTC time offset in the output of uftrace info. This number can be used to make time adjustment easier for external tools such as tracecompass[1]. Closes: namhyung#1916 [1] https://eclipse.dev/tracecompass Requested-by: Matthew Khouzam <matthew.khouzam@gmail.com> Signed-off-by: Honggyu Kim <honggyu.kp@gmail.com>
honggyukim
force-pushed
the
check/utc-offset
branch
from
d74c7d2 to
0ac2cef
Compare
In some cases, there is a requirement to get the time offset between UTC time and our timestamp from the given clock source, CLOCK_MONOTONIC by default.
This patch provides an additional info to provide UTC time offset in the output of uftrace info.
This number can be used to make time adjustment easier for external tools such as tracecompass[1].
Closes: #1916
[1] https://eclipse.dev/tracecompass
Requested-by: Matthew Khouzam matthew.khouzam@gmail.com
Signed-off-by: Honggyu Kim honggyu.kp@gmail.com