Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MP3 Tag Reading does not work correctly #12

Closed
CaptainKarma opened this issue Oct 8, 2023 · 4 comments
Closed

MP3 Tag Reading does not work correctly #12

CaptainKarma opened this issue Oct 8, 2023 · 4 comments

Comments

@CaptainKarma
Copy link

Namida looks great but after scanning my 40k library its reporting I have 21 Albums, 9 Genres and the Artists screen doesn't function at all.

Let me know how I can help debug this. I tried to fork it but there are lots of flutter dependencies that aren't available so I couldn't build it.

Thanks

Screenshot_20231008-171559

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 8, 2023

thank you 🌺

  1. since there are some albums and genres extracted, it means that the indexer is working fine, the issue is only with specific files
  2. while indexing, if, for any reason, info couldn't be extracted, Namida tries to put title & artist from filename
  3. artists in screenshot seems like they been extracted from filename
  4. please share logs at /storage/emulated/0/Android/data/com.msob7y.namida/files/logs.txt
  5. as for building, there are some libraries of mine made private, i dont want people stealing code for now, but they should be public if it ever got recognition, sorry for that

@CaptainKarma
Copy link
Author

All my mp3 files are properly tagged with id3v2.3 and in a folder structure of artist/album/01 - filename.mp3

  1. Please find attached
  2. Sure ok, understood

Let me know if I can help further, thanks

logs.txt

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 8, 2023

@CaptainKarma
uhmm the logs doesnt say much, im thinking about adding ffmpeg tag reading as a fallback but it takes longer than the native tagger, can u please send some samples (2-3) of the audio files on telegram or on discord ? sorry for the inconvenience

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 9, 2023

ce481c7 ffmpeg added as a fallback tag reader

  • with some optimizations, performance is almost the same, at worst it might be 10% slower (due to separate artwork extraction) but overall this should fix it, still better to provide samples tho

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants