Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Confirmation Dialogs #120

Closed
z9xx7o0 opened this issue Feb 1, 2024 · 3 comments
Closed

[FEATURE REQUEST] Confirmation Dialogs #120

z9xx7o0 opened this issue Feb 1, 2024 · 3 comments

Comments

@z9xx7o0
Copy link

z9xx7o0 commented Feb 1, 2024

It would be amazing if you could add a confirmation popup in certain places like:

  • remove from playlist
  • add tracks to a playlist
  • adding duplicate tracks

It is annoying when I accidentally add tracks to the wrong playlist or removing tracks from the playlist accidentally or adding duplicate tracks and having to remove them, so I think adding this might help.

@MSOB7YY
Copy link
Member

MSOB7YY commented Feb 1, 2024

  1. removing from a playlist:
    • u already get an undo button when u remove something, this is better for faster removal, in the same time it's unlikely to accidentally remove tracks, u have to either press that in a dialog or manually enable reordering/removing then remove a track
  2. adding to playlist:
    • also not a good idea, its pain, pls be careful with ur touches. most players/services adds without confirmation already, at least all i have used.
  3. adding duplicate tracks:
    • this might be good but what about when adding some tracks of which only few of them are duplicated? im thinking about showing dialog with 3 options:
      1. add all and remove old ones
      2. add only missing
      3. add all tracks

@z9xx7o0
Copy link
Author

z9xx7o0 commented Feb 1, 2024

Good point 👍. Just a suggestion, if you don't like the confirmation popup for adding to a playlist, please consider adding an undo button just like the one with the remove button. It will do the same thing without much interruption.

@MSOB7YY MSOB7YY changed the title feature request [FEATURE REQUEST] Confirmation Dialogs Feb 1, 2024
@MSOB7YY MSOB7YY closed this as completed in 5c832b0 Feb 5, 2024
@NikunjKhangwal
Copy link

What about deleting playlist? The delete button is on the lower end of screen and undo button appears at the very top of screen creating a displacement gap. There's more chances of missing it. I would suggest to have the undo button pop-up around the same area as delete if confirmation dialogue isn't possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants