Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing Tags corrupts files (changes duration of songs) #129

Closed
f4b4d1 opened this issue Feb 19, 2024 · 4 comments
Closed

Editing Tags corrupts files (changes duration of songs) #129

f4b4d1 opened this issue Feb 19, 2024 · 4 comments

Comments

@f4b4d1
Copy link

f4b4d1 commented Feb 19, 2024

When editing a songs tags and douple tapping on save while listening to it, the duration gets shortend when starting it again after another song has played.
Discovered it yesterday as I was naming some 1 hour long mixes on my phones SD-card. Sometimes I tapped a second time on "Save". When starting the song again it seems like the already listened part got cropped out and only the not listened part is left in the file. (The whole file size gets altered)

Steps to reproduce:
0. Have a Backup of Song A

  1. Start a (long) song (Song A) and skip into the middle of the song
  2. Edit tags of Song A (e.g. change Title)
  3. Double-Tap on Save
  4. Start a different song (Song B)
  5. Start Song A again.
  6. Compare duration of Song A before and after editing the tags
@MSOB7YY
Copy link
Member

MSOB7YY commented Feb 19, 2024

holy shit that's true
damn, it seems like the issue happens only when double tapping "save", am i correct?
thats obviously due to concurrent writing to the same file, making it corrupted, gonna disable save button while saving
have u encountered a similar issue just by tapping "save" (not double tapping) ?

@f4b4d1
Copy link
Author

f4b4d1 commented Feb 19, 2024

I tried several times with just tapping once, but it only happend with double tapping.
I tapped a second time because saving took a little bit longer for the long songs. After that I thought they were gone (sorted by duration) but they were just shortend.

@MSOB7YY
Copy link
Member

MSOB7YY commented Feb 20, 2024

now the button will be disabled while saving, sorry for the issues caused.
if u want u can use the snapshot build from https://github.com/namidaco/namida/actions/runs/7966602874 (it will be separate version)

@f4b4d1
Copy link
Author

f4b4d1 commented Feb 20, 2024

No problem, fourtunately I noticed it early in the process.
Thanks for the quick fix and keep up the good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants