Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Selecting tracks that have duplicates #179

Closed
z9xx7o0 opened this issue Apr 20, 2024 · 2 comments
Closed

[BUG] Selecting tracks that have duplicates #179

z9xx7o0 opened this issue Apr 20, 2024 · 2 comments

Comments

@z9xx7o0
Copy link

z9xx7o0 commented Apr 20, 2024

Trying to manually remove duplicate tracks from a playlist.

Expected behaviour

When selecting a track, it should be individually highlighted and selected without its duplicate.

Current Behaviour

1- When selecting a track that has a duplicate, the duplicate is highlighted without it actually being selected.

2- When unselecting the duplicate, the original's highlight gets removed without it being unselected.

3- When reselecting the track, the menu has a ghost track that doesn't exist, but it is being counted.

fixed/implemented?-->

Steps to Reproduce

  1. Have a playlist with duplicate tracks

  2. Select one of them by long pressing. The other one gets highlighted without being selected.

  3. Tap on the duplicate to remove the highlight, and the highlight from the original gets removed.

  4. Tap on the original to rehighlight it, which causes the menu to say 2 are selected while only one is selected.

  5. Repeat steps 3 and 4 many times.

  6. The menu will have ghost tracks that don't exist.

Screenshots

Screenshot_20240420_205251.png

Logs

Possible Solution

@z9xx7o0 z9xx7o0 changed the title [BUG] [BUG] Selecting tracks that have duplicates Apr 20, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 21, 2024

if you just want to remove duplicates, why not use this button?
playlist menu -> third button here
image

however i reproduced the bug, totally not the intented behavior. gonna fix the ghost tracks and push.

note that the behavior will not change, selecting a track will still highlight all the other duplicates as if they were selected too, its nonsense that one might want to select same track again

@MSOB7YY
Copy link
Member

MSOB7YY commented Apr 21, 2024

this was fixed in 07f4575, u can use the beta build if u wish. btw the ghost was a ui issue, otherwise the list would display all of the ones u selected

@MSOB7YY MSOB7YY closed this as completed Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants