Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can't import my music library #18

Closed
Joeeeeb5 opened this issue Oct 12, 2023 · 6 comments
Closed

can't import my music library #18

Joeeeeb5 opened this issue Oct 12, 2023 · 6 comments

Comments

@Joeeeeb5
Copy link

Instead of the junk you get hit with when opening the app, you should be able to select a folder and the app scans just that folder quickly. Other music player apps like Poweramp and Oto music were able to import all 400 of my songs in a couple of seconds but this was able to find half of them in over a minute and stopped after that

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 12, 2023

what are you expecting from a music player other than scanning ur music files? i cant let the initial folders empty and ppl open it and find it empty, but good suggestion i may add a welcome screen with initial folders

the jank u are talking about is normal with "indexing", poweramp and oto doesn't really "index", they just read them from Media Store, so obviously it will be fast/instant and not laggy, while Namida extracts info from the files themselves, there are some info can't be provided by Media Store so we use the actual files and actual extraction process, u dont spend ur time extracting ur library so scan once enjoy later

and what do you mean by "cant add my music library?" there are list of folders to scan from, if ur music exists in a folder that is not default music folder, just simply add that folder from Indexer :/

@MSOB7YY MSOB7YY closed this as completed Oct 12, 2023
@Joeeeeb5
Copy link
Author

and what do you mean by "cant add my music library?" there are list of folders to scan from, if ur music exists in a folder that is not default music folder, just simply add that folder from Indexer :/

Like, I have 400 songs and around 250 lrc files in my music folder but namida couldn't index all music for some reason

@Joeeeeb5
Copy link
Author

the jank u are talking about is normal with "indexing", poweramp and oto doesn't really "index", they just read them from Media Store, so obviously it will be fast/instant and not laggy, while Namida extracts info from the files themselves, there are some info can't be provided by Media Store so we use the actual files and actual extraction process, u dont spend ur time extracting ur library so scan once enjoy later

Hmmm, interesting. What positive things does indexing have over just reading the files? I find that my artists and albums are organized and searching is instant either way

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 12, 2023

@Joeeeeb5

  • as for lrc: im working on lrc support with animated synced screen, its almost done (check Feature Request - .lrc file support #6)
  • as for indexing: try the latest snapshot in Telegram chat, some people reported and got fixed with that version, if you made sure u added your library folders, tried the snapshot, and it indicates that it was indexing (400) track in Indexer settings, then share logs on the chat
  • i also worked on a minimal algorithm which speeds up indexing by 250%, will be available in next release

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 12, 2023

Media Store doesnt provide some of the main fields that Namida relies on and considered critical, for example comment tag, which should have a youtube link to the music which allows u to

  1. fetch that video and automatically and play it along with music
  2. import youtube history, which later be useful for all other functionalities (like recommended tracks) if u just started using the app

u will also lose lyrics tag (which should be used to display lyrics), mood tag, along with other tag fields which might or might not be useful for u

also, by using media store, you will be bounded to their other api thingys, like albums, artist, genres, playlists, etc.. even all these sorting u see in namida, most of them wont be availabe

also there is artwork, u can

  • fetch them every time but u will lose fast color extraction (since u will have to wait for artwork first everytime) which will make auto coloring pointless
  • or u can fetch em all and save to app cache, and thats what we already do that with current indexer

add, respect.nomedia option will have no effect, since media store automatically ignores folders with .nomedia

thats what i remember for now, i chose this way bcz its felixible and opens the door for any feature without limitation, hope u understand

@Joeeeeb5
Copy link
Author

@Joeeeeb5

  • as for lrc: im working on lrc support with animated synced screen, its almost done (check Feature Request - .lrc file support #6)
  • as for indexing: try the latest snapshot in Telegram chat, some people reported and got fixed with that version, if you made sure u added your library folders, tried the snapshot, and it indicates that it was indexing (400) track in Indexer settings, then share logs on the chat
  • i also worked on a minimal algorithm which speeds up indexing by 250%, will be available in next release

Thanks for your responses! I'll try the next version and give feedback on it too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants