-
-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Editing/updating tags and saving, playing this track it is still the old tag? #181
Comments
regardless, fabulous app. hands down my new fav. any chance itll ever make it to the play store? |
i can't reproduce, i have tested this many times and it instantly updates the details, not sure what going wrong on ur side, can u provide a quick video and the logs? here is what happens when u edit tags: editing_tags.mp4 |
also ty so much <333 play store is probably not possible, we got an yt client that supports downloading so lmao.. also the |
oh totally didnt think about that. dur. thx. in response to the bug though, it only happened once so far, and i did not try to reproduce. i only edited one tag total, because it was not tagged previously. the player just took the file name as the track title. i still have the original file, but ill have to remove it and copy it over from my pc. as you say this doesnt usually happen and i believe you, can you perhaps check with a track that has no metadata, and add metadata? |
if it had the filename as track title (i.e: tried parsing file name to artist - title), then this means that the tags couldnt be extracted, and most probably will not be editable(?) cuz usually some of them are kinda corrupted i checked with a track that has no tags, edited artist field, it was then updated in namida but not the actual file. if ur case is similar then probably nothing we can do about it. u better download from official source or use scripts like yt-dlp |
got it. ya it was that, coincidentally from a different yt method... Usually I purchase/rip flac. I'll just convert and fix tags manually for anything like that. Thanks for explaining. Anyway of some kind of notification of corruptness, or do you know of any mac app that can check for that? Closing. |
usually it should report any error if failed, not sure what exactly happened in ur case since no video or logs. feel free to reopen in case ur issue was still not fixed lib/ui/dialogs/edit_tags_dialog.dart._editSingleTrackTagsDialog]( namida/lib/ui/dialogs/edit_tags_dialog.dart Lines 458 to 468 in 07f4575
i dont use mac so idk sry, but with simple search i think |
edited Both logs I have, lmk when you get em? Don't see what you're looking for though.... |
Expected Behavior
the track/s tag should auto update after clicking save. instead you have to do a library refresh. this is confusing.
Current Behavior
it remains the same in all parts of the player except "edit tag" until you go to index and refresh
Steps to Reproduce
Screenshots
Logs
Possible Solution
The text was updated successfully, but these errors were encountered: