Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Bilingual lyrics, with the two languages displayed in separate lines(Edited) #195

Closed
darkduck9 opened this issue May 16, 2024 · 11 comments

Comments

@darkduck9
Copy link

darkduck9 commented May 16, 2024

Edited:correct lyrics have been updated.

Is your feature request related to a problem? Please describe
Pls support the display of bilingual lyrics.
When there are two lyrics with the same timestamp, Namida can only display the latter one.

Lyrics format:
06

Describe the solution you'd like
the lyric and its translation can be displayed in separate lines,the translation should not be highlight

Describe alternatives you've considered
just like the follow pic

Additional context
ESLyric✔️
4
Namida❌
12
(updated for test) Keep You Mine - NOTD.zip
Apps
foobar ESLyric plug-in https://github.com/ESLyric/release?tab=readme-ov-file
netease music web https://music.163.com/#/song?id=1381706037

@darkduck9 darkduck9 changed the title [FEATURE REQUEST] Bilingual lyrics, with the two languages displayed in separate lines [FEATURE REQUEST] Bilingual lyrics, with the two languages displayed in separate lines(Edited) May 18, 2024
@darkduck9
Copy link
Author

I also found that Retro Music supports this feature. Embedding the lyric source might be difficult (but that's okay). I hope Namida can display embedded lyrics 4

@MSOB7YY
Copy link
Member

MSOB7YY commented Jun 1, 2024

I'm just tryna figure out how the second language is identified. looking at the lrc file it seems that it only has double space " " but is it really that simple? can't seem to find info online too

@darkduck9
Copy link
Author

3

Honestly, I used the Music Tag software to batch edit audio tags and lyrics. It can retrieve information from various music platforms and modify it into a specified lyric format.Here is link:https://www.cnblogs.com/vinlxc/p/11347744.html,

Of course, using a double space " " is also a format that can separate the original text from the translation.
I think if treat the earlier lyrics on the same timeline as the original text, and the later ones as the translation,
it may be easier to implement the effect using code.

Sorry, the test file has been updated 2 weeks ago. Please download it again.

@MSOB7YY
Copy link
Member

MSOB7YY commented Jun 1, 2024

i see, it makes sense now that translation line has same timestamp as original. alr will eventually implement it. just curious if double space is still a valid format? or if there are more alternatives to these two? thanks for the detailed request and sample files tho

@darkduck9
Copy link
Author

8
If you choose the first format in the image, you can customize the delimiter between the original text and the translation. As far as I know, only NetEase (source 163) uses the double space " " format.

@darkduck9
Copy link
Author

I'm not sure if you can download Music Tag from the original link if you're in another country.

If you need it, here's the link and the extraction code: www.coolapk.com, https://mega.nz/file/HIxzAYoY#eEL6MQBcPFfOYUT8IqF53S8myT1yaw1DcJ_zR7qiU1s

@MSOB7YY
Copy link
Member

MSOB7YY commented Aug 28, 2024

hey, just finished working on this now. bilinguals lyrics will now be supported if they follow one of these format

  • double space: [00:06.87]Yes we started a fire, now the bedroom is burning 我们点燃了一场火,现在卧室正燃着熊熊大火
  • semicolon: [00:13.99]'Cause we're both saying things that we're gonna regret when;我们总会说一些令人后悔的事
  • this thing | : [00:19.16]Every word's too loud|每个字都是那么刺耳
  • just normal 2 lined with the same timestamp:
[00:21.12]We gotta slow, slow, slow down
[00:21.12]我们只需要冷静下来

done in 4a71dd4 (v4.0.55) & MSOB7YY/dart_lrc@d95622b, u may check it in beta from here https://github.com/namidaco/namida-snapshots/releases when its released

thanks for reporting & for providing a test stuff! much luvv <33

@MSOB7YY MSOB7YY closed this as completed Aug 28, 2024
@VerySweetBread
Copy link

IMHO,

  • Double spaces might be a TYPO
  • semicolons might be in a regular text (ex)
  • Pipes and double timestamp are good options

@MSOB7YY
Copy link
Member

MSOB7YY commented Aug 28, 2024

@VerySweetBread always russian ruining the fun

  • the semicolon are in english too so uhh should we just remove it?
  • double spaces typo may be a sign to fix ur lyrics. there are more chances of it being multi-lang than being a typo

@MSOB7YY
Copy link
Member

MSOB7YY commented Aug 30, 2024

@darkduck9 @VerySweetBread just removed ; as splitter MSOB7YY/dart_lrc@3a9fa81

now the supported are only |, & normal 2 separate lines

@darkduck9
Copy link
Author

New feature worked well,thx for your work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants