Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST] Crop youtube topic channels thumbnail #212

Open
JayDean5 opened this issue May 27, 2024 · 3 comments
Open

[FEATURE REQUEST] Crop youtube topic channels thumbnail #212

JayDean5 opened this issue May 27, 2024 · 3 comments

Comments

@JayDean5
Copy link

JayDean5 commented May 27, 2024

When downloading the music, in my opinion, not all people don't want rectangle album cover, thank you!

So the album cover won't appear like this

Screenshot_20240527_194208

@JayDean5 JayDean5 changed the title [FEATURE REQUEST] Automatically force squared album cover when downloading the music, in my opinion, not all people dont want rectangle album cover, thank you! [FEATURE REQUEST] Automatically force squared Album cover May 27, 2024
@MSOB7YY
Copy link
Member

MSOB7YY commented May 29, 2024

cool that's for videos with music only, what about other normal videos?
currently we dont do any modifications to the downloaded files, video/audio/image, everything stays to original (with filling metadata ofc)

@lovegaoshi
Copy link

this is an annoying issue relevant to android < 13 and samsung. prior to android 13 I believe notif shows squares like the screenshot linked. google introduced the "immersive" notification in android 13 where the album art is shown as landscape, and cropping to suqare looks uglier than the original landscape shape.
samsung prior to oneUI6/android 14 always shows a square. in oneUI6 samsung introduced the same immersive notification but 1. samsung crops it themselves too, but annoyingly in the landscape view; and 2. the immersive notification can be swiped up and shows a square, but samsung does not crop that. So for samsung its better to just crop to square.

perhaps more clearly illustrated in the screenshots i posted below:
doublesymmetry/KotlinAudio#79

and this applies to all YTM, YT covers (all are landscape) and whatever embedded album covers that are not squares.

@MSOB7YY
Copy link
Member

MSOB7YY commented May 29, 2024

meanwhile here with android 10 style colored notification ☠️

@MSOB7YY MSOB7YY changed the title [FEATURE REQUEST] Automatically force squared Album cover [FEATURE REQUEST] Crop youtube topic channels thumbnail May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants