Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some songs just aren't playing #42

Closed
NikunjKhangwal opened this issue Oct 30, 2023 · 5 comments
Closed

Some songs just aren't playing #42

NikunjKhangwal opened this issue Oct 30, 2023 · 5 comments

Comments

@NikunjKhangwal
Copy link

First of all i like your app a lot, it's very unique. It ticks most of the boxes for me and I've enjoyed using it however this is a one major problem I'm facing

Screenshot_2023-10-30-12-07-27-488_com msob7y namida

The app showed "error playing track" in few songs

Screenshot_2023-10-30-12-07-29-790_com msob7y namida

So i tried updating it

Screenshot_2023-10-30-12-07-35-189_com msob7y namida

Even tho the file hasn't been deleted, moved or renamed outside of Namida (as you can see the new name is same as old one) it's still not working after confirming the option

Screenshot_2023-10-30-12-07-41-455_com msob7y namida

I tried updating path directory and reindexing the artwork too but still no luck. I tried playing them in Poweramp, Musicolet and Metro and they're playing fine. I don't know what's happening exactly.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 30, 2023

hmmmmm interesting, thanks for liking Namida tho

well the issue seems kinda weird, i would say all_file_access permission is needed it the track was in a root directory, but its not.

i can't predict any possible reason except that the file contains #, can you please send this track and share the logs from "About section"?
also can u confirm other music is playing normally inside "storage/emulated/0/Music"? sorry for inconvenience

@NikunjKhangwal
Copy link
Author

Turns out that was exactly the problem. Every file with # in title wasn't playing but they played normally after i renamed them.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 30, 2023

that makes sense, I have pushed a fix in ef6e809 which fixes this issue, sorry for inconvenience, and thanks again for ur nice review & detailed bug issue 🌺

@MSOB7YY MSOB7YY closed this as completed Oct 30, 2023
@NikunjKhangwal
Copy link
Author

Thanks for your efforts. While i'm at it, can i suggest a few other things as well here or should i open seperate issues for them? Sorry for the dumb question idk much about how github works.

@MSOB7YY
Copy link
Member

MSOB7YY commented Oct 30, 2023

ofc you can! I would love to hear more!
but its better to open a new issue since it will have different topic, ty

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants