Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SUGGESTION] A Floating Search Button #47

Closed
NikunjKhangwal opened this issue Nov 2, 2023 · 6 comments
Closed

[SUGGESTION] A Floating Search Button #47

NikunjKhangwal opened this issue Nov 2, 2023 · 6 comments

Comments

@NikunjKhangwal
Copy link

A Floating search button would be great for ease of use. The place directly over mini player is perfect for thumb placement.
A few other ideas i have:-
An option to make it disappear temporarily while scrolling up.
It should follow the same color as song artwork just like mini player does.
It should work in every list like albums, artists and youtube.

IMG_20231102_145444

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 2, 2023

hellow, this sounds like a great idea, but it will kind of break the design

currently you can include search button in bottom navigation bar, which seems very good option for me
Screenshot_20231102-123753_Namida

  • to tweak library tabs, go to settings > extra > library tabs, then add/reorder/remove
  • let me know if this is a good solution, i don't think i can add a floating button

@NikunjKhangwal
Copy link
Author

I feel like navigation bar gets a bit cluttered, it already has a lot of buttons. It's a matter of personal preference, i thought a floating button would be easier to use. But search in navigation bar is also usable for now. 👍

@BlackSparkz
Copy link

A Floating search button would be great for ease of use. The place directly over mini player is perfect for thumb placement.
A few other ideas i have:-
An option to make it disappear temporarily while scrolling up.
It should follow the same color as song artwork just like mini player does.
It should work in every list like albums, artists and youtube.

IMG_20231102_145444

Not search button place suffle button

@MSOB7YY
Copy link
Member

MSOB7YY commented Nov 30, 2023

okay this was implemented in 302bfd6 & 0031d46

  • optioned to none, shuffle or search (other ideas are welcomed)
  • it hides when scrolling up in tracks page only
  • it always shows while search box is shown (to clear and close search)
  • shuffling supports local tracks only now (i still didnt trace youtube pages, its quite pain)
  • it follows the current color scheme ofc

thanks for the suggestion 🌺

@MSOB7YY MSOB7YY closed this as completed Nov 30, 2023
@NikunjKhangwal
Copy link
Author

Holy! You're the 🐐 for implementing niche stuffs that weren't initially planned so quickly.

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 1, 2023

@NikunjKhangwal
mughhaghhagha what can i say 🤷.. i got some cute users i cant say no 😺

thank you again 💖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants