Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Suggestion] Reminder when there is no youtube link #83

Closed
NikunjKhangwal opened this issue Dec 10, 2023 · 6 comments
Closed

[Feature Suggestion] Reminder when there is no youtube link #83

NikunjKhangwal opened this issue Dec 10, 2023 · 6 comments

Comments

@NikunjKhangwal
Copy link

The "Open YouTube Link" button should show a toast message clarifying when there's no youtube link available for the song. That's it

@NikunjKhangwal
Copy link
Author

Btw the new update is nice. After using it for some time now, the app is much easier to navigate around and I'm genuinely having a good time using it.

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 11, 2023

first thank you for ur words, glad u having a better experience!

about showing a toast/message

  • if you are referring to this button (inside track menu), then this should be showed already when there is no YouTube link for the track (screenshot below)
    Screenshot_20231211-151640_Namida

  • if you are referring to opening external links (by sharing to namida) then this will not be possible, since the process of identifying youtube links goes through some stages, the shared intent is just text that can be:

    1. YouTube link
    2. M3U Playlist
    3. normal file
    4. any other thing

    that's why giving a clear decision that the text wasn't YouTube link can't be given

let me know if u meant smth else

@idontveapc
Copy link

what is that language??

@MSOB7YY
Copy link
Member

MSOB7YY commented Dec 11, 2023

@idontveapc mugahaghhaha it's an incorrectly encoded track tags (non UTF-8 i guess)
i keep it for tests

@idontveapc
Copy link

😁:shipit:

@NikunjKhangwal
Copy link
Author

Ah! I see. I meant the first one. Either i didn't noticed the message or it got overriden by something else. Thanks for clarifying.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants