Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support POST/multipart Guzzle requests #1

Open
cirpo opened this issue Sep 1, 2014 · 3 comments
Open

support POST/multipart Guzzle requests #1

cirpo opened this issue Sep 1, 2014 · 3 comments

Comments

@cirpo
Copy link
Collaborator

cirpo commented Sep 1, 2014

No description provided.

@Avariya
Copy link

Avariya commented Sep 4, 2016

Start to fix this problem, but can't reproduce it anymore. May you test is it still reproducible?

@cirpo
Copy link
Collaborator Author

cirpo commented Sep 5, 2016

@Avariya will do

@Avariya
Copy link

Avariya commented Sep 8, 2016

Ok. I found out that it fails at big files through multipart because of PHP max command length is 8192 at Win and 4096 at Linux.
https://github.com/php/php-src/blob/master/ext/standard/exec.c#L57
So escapeshellarg first of all checks is command it needs to escape longer than max one.
Need add trimming.
As an idea - trim to 4000 symbols or trim platformbase

Or use self written function like:

$input = str_replace('\'', '\\\'', $input);
return '\''.$input.'\'';

What kind of pull request should I create?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants