-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve ChibiOS memory functions #2634
Conversation
I was reviewing this code and just realized that it's reverting a global rework for platform malloc/free done in #2076 Reverting this requires testing on all STM32 targets. |
02e0d18
to
591537f
Compare
Switching to CH heap requires changing the memory allocation config in all SMT32 targets and retest everything, specially the network and TLS stuff. 😱 |
Closing as |
Warning Rate limit exceeded@nfbot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 4 minutes and 9 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
This PR provides the platform specific implementation of memory (free, malloc, realloc) functions for ChibiOS.
Motivation and Context
We currently just revert to the generic functions which may cause issues since other functions within the RTOS are using the heap in a different way.
If this is not required, we should seriously reconsider the use of
platform_heap
as all targets currently use the generic (default) implementation.How Has This Been Tested?
Tested ability to run locally on an STM32F769I
May need further tests to ensure full compatibility (although please give examples of what needs testing).
Screenshots
Types of changes
Checklist