-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve storage #2868
Improve storage #2868
Conversation
could possibly optimize out memcpy, but that is for later.
Further improve file name
Automated fixes for code style.
…580c-196b-48c8-9817-cca5540acfc8 Code style fixes for nanoframework/nf-interpreter PR#2849
Correct char number
Automated fixes for code style.
…3d99-1b61-4b86-b7ec-cf78dfdbc883 Code style fixes for nanoframework/nf-interpreter PR#2849
Can be used as future reference.
Automated fixes for code style.
…72d0-b907-47c4-94d3-c9f48328d7c2 Code style fixes for nanoframework/nf-interpreter PR#2868
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That look indeed cleaner :-)
@@ -47,8 +56,8 @@ typedef enum StorageEventType | |||
|
|||
// constants to be used throughout the code | |||
#define SUPPORTED_DRIVES_COUNT (2) | |||
#define DRIVE_LETTER_LENGTH sizeof(INDEX0_DRIVE_LETTER) | |||
#define DRIVE_PATH_LENGTH sizeof(INDEX0_DRIVE_PATH) | |||
#define DRIVE_LETTER_LENGTH (2) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why changing for 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My reasoning was that we know the length, so why base it off of a static field that should never change (as a compiler optimization. Happy to revert it though.
Closing as obsolete. |
Warning Rate limit exceeded@nfbot has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 25 minutes and 24 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Description
Motivation and Context
work towards #2849
How Has This Been Tested?
Screenshots
Types of changes
Checklist