Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixes to mpuconf for STM32F7 series #2890

Closed
wants to merge 2 commits into from

Conversation

networkfusion
Copy link
Member

@networkfusion networkfusion commented Mar 3, 2024

Description

Here is a speculative fix for STM32F7 series MCU's. The fix might need adjustment to align with our memory map(s).

Motivation and Context

As found at ArduPilot/ChibiOS.svn@ad5f683

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • New Features

    • Enhanced configuration options for STM32 microcontrollers, including improved cache management and memory protection settings.
    • Introduced a new initialization behavior option for better control during startup.
  • Bug Fixes

    • Resolved issues related to previous memory management configurations, leading to improved system stability.

@networkfusion networkfusion changed the title Add fixes to mpuconf for STM32F7 series DO NOT MERGE: Add fixes to mpuconf for STM32F7 series Mar 3, 2024
@networkfusion networkfusion added ⚠️ DO NOT MERGE ⚠️ Platform: STM32 Everything related specifically with ChibiOS platform labels Mar 3, 2024
@networkfusion networkfusion changed the title DO NOT MERGE: Add fixes to mpuconf for STM32F7 series Add fixes to mpuconf for STM32F7 series Mar 3, 2024
@josesimoes
Copy link
Member

Implemented in #2911, therefore OK to close.

@networkfusion
Copy link
Member Author

Closing as fixed.

@networkfusion networkfusion deleted the mpuconf-fixes branch July 23, 2024 13:22
@nfbot nfbot added invalid and removed ⚠️ DO NOT MERGE ⚠️ Platform: STM32 Everything related specifically with ChibiOS platform labels Jul 23, 2024
Copy link

coderabbitai bot commented Jul 23, 2024

Caution

Review failed

The pull request is closed.

Walkthrough

The recent modifications to the mcuconf.h files for various STM32F7xx microcontrollers focus on enhancing performance and flexibility. Key changes include enabling cache functionality and introducing memory protection unit (MPU) settings. The STM32_NO_INIT configuration has been standardized across files, impacting initialization behavior. Overall, these updates aim to streamline memory management and optimize system performance.

Changes

Files Change Summary
targets/ChibiOS/ORGPAL_PALTHREE/nanoBooter/mcuconf.h, targets/ChibiOS/ORGPAL_PALTHREE/nanoCLR/mcuconf.h Enabled cache (STM32_NOCACHE_ENABLE to TRUE), added MPU configurations, and standardized STM32_NO_INIT to FALSE.
targets/ChibiOS/ST_STM32F769I_DISCOVERY/nanoBooter/mcuconf.h, targets/ChibiOS/ST_STM32F769I_DISCOVERY/nanoCLR/mcuconf.h Similar changes as above: enabled cache, added MPU settings, and defined STM32_NO_INIT as FALSE. Removed STM32_SRAM2_NOCACHE definition.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants