-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PalX ADC config #2962
Fix PalX ADC config #2962
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Automated fixes for code style.
Isn't this more than OK to merge? |
@josesimoes although the changes are valid, it needs your expert attention to work out why there are still issues with the ADC channel changes in comparison to the Pal3. I did not think it worth merging before all were working and correct. |
For reference, the test program I used was: https://github.com/networkfusion/orgpal-x-demo/tree/test |
@josesimoes and... I still cannot work out why this PR is building for the wrong boards! |
cadbd8b
to
94d5700
Compare
f1c86c5
to
449142a
Compare
@networkfusion fixed in #3007 along with other wrong GPIO assignments. |
Description
Improves the PalX ADC configuration after input from @gligorov.
It is now able to read the thermistor port correctly.
Motivation and Context
Temperatures were not working correctly.
How Has This Been Tested?
Screenshots
Types of changes
Checklist