-
-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate IDF to v5.1.4 #2975
Migrate IDF to v5.1.4 #2975
Conversation
- Bump versions in dev containers. - Bump versions in revision counters for builds. - Update tag in ESP32 build components cache.
WalkthroughThe updates primarily involve incrementing versions for Docker images, ESP-IDF repository tags, and version counters across multiple components like ESP32, STM32, TI SimpleLink, and Azure RTOS. These changes enhance consistency, maintain compatibility, and integrate new features or improvements in the updated versions. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (9)
- .devcontainer/All/Dockerfile.All (1 hunks)
- .devcontainer/All/Dockerfile.All.SRC (1 hunks)
- .devcontainer/ESP32/Dockerfile.ESP32 (1 hunks)
- .devcontainer/ESP32/Dockerfile.ESP32.SRC (1 hunks)
- azure-pipelines-nightly.yml (5 hunks)
- azure-pipelines-templates/download-install-esp32-build-components.yml (1 hunks)
- azure-pipelines.yml (7 hunks)
- targets/ESP32/CMakeLists.txt (1 hunks)
- version.json (2 hunks)
Files skipped from review due to trivial changes (6)
- .devcontainer/All/Dockerfile.All
- .devcontainer/All/Dockerfile.All.SRC
- .devcontainer/ESP32/Dockerfile.ESP32
- .devcontainer/ESP32/Dockerfile.ESP32.SRC
- targets/ESP32/CMakeLists.txt
- version.json
Additional context used
yamllint
azure-pipelines-templates/download-install-esp32-build-components.yml
[error] 1-1: wrong new line character: expected \n
(new-lines)
azure-pipelines-nightly.yml
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 49-49: trailing spaces
(trailing-spaces)
[error] 57-57: trailing spaces
(trailing-spaces)
[error] 62-62: trailing spaces
(trailing-spaces)
[error] 102-102: trailing spaces
(trailing-spaces)
[error] 103-103: trailing spaces
(trailing-spaces)
[error] 104-104: trailing spaces
(trailing-spaces)
[error] 106-106: trailing spaces
(trailing-spaces)
[error] 118-118: trailing spaces
(trailing-spaces)
[error] 128-128: trailing spaces
(trailing-spaces)
[error] 139-139: trailing spaces
(trailing-spaces)
[error] 173-173: trailing spaces
(trailing-spaces)
[error] 178-178: trailing spaces
(trailing-spaces)
[error] 210-210: trailing spaces
(trailing-spaces)
[error] 229-229: trailing spaces
(trailing-spaces)
[error] 502-502: trailing spaces
(trailing-spaces)
azure-pipelines.yml
[error] 1-1: wrong new line character: expected \n
(new-lines)
[error] 39-39: trailing spaces
(trailing-spaces)
[error] 80-80: trailing spaces
(trailing-spaces)
[error] 94-94: trailing spaces
(trailing-spaces)
[error] 98-98: trailing spaces
(trailing-spaces)
[error] 132-132: trailing spaces
(trailing-spaces)
[error] 134-134: trailing spaces
(trailing-spaces)
[error] 140-140: trailing spaces
(trailing-spaces)
[error] 148-148: trailing spaces
(trailing-spaces)
[error] 156-156: trailing spaces
(trailing-spaces)
[error] 167-167: trailing spaces
(trailing-spaces)
[error] 168-168: trailing spaces
(trailing-spaces)
[error] 169-169: trailing spaces
(trailing-spaces)
[error] 170-170: trailing spaces
(trailing-spaces)
[error] 173-173: trailing spaces
(trailing-spaces)
[error] 174-174: trailing spaces
(trailing-spaces)
[error] 175-175: trailing spaces
(trailing-spaces)
[error] 177-177: trailing spaces
(trailing-spaces)
[error] 191-191: trailing spaces
(trailing-spaces)
[error] 235-235: trailing spaces
(trailing-spaces)
[error] 246-246: trailing spaces
(trailing-spaces)
[error] 247-247: trailing spaces
(trailing-spaces)
[error] 309-309: trailing spaces
(trailing-spaces)
[error] 315-315: trailing spaces
(trailing-spaces)
[error] 674-674: trailing spaces
(trailing-spaces)
Additional comments not posted (5)
azure-pipelines-templates/download-install-esp32-build-components.yml (1)
9-10
: Update cache keys to version 5.1.4The cache keys for ESP32 tools have been updated to reflect the new version
5.1.4
. Ensure that these keys are unique across different builds to avoid potential cache collisions.azure-pipelines-nightly.yml (2)
296-296
: Update revision counters for different platformsThe revision counters for STM32, ESP32, TI SimpleLink, and Azure RTOS have been updated to be in sync with the new version
1.10.0
. This is a crucial update to maintain the build versioning integrity.Also applies to: 547-547, 623-623, 674-674
20-20
: Update ESP-IDF version referenceThe ESP-IDF version reference has been updated to
v5.1.4
. This change should be cross-verified with other configuration files to ensure consistency across the entire project.Verification successful
Update ESP-IDF version reference
The ESP-IDF version reference has been updated to
v5.1.4
inazure-pipelines-nightly.yml
. The verification shows no inconsistencies in ESP-IDF version references across the configuration files.
azure-pipelines-nightly.yml
: Line 20Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Verify consistency of ESP-IDF version across configuration files. # Test: Search for ESP-IDF version references. Expect: Only occurrences of version 5.1.4. rg --type yaml --type yml 'esp-idf' | rg 'v5\.1\.4'Length of output: 79
Script:
#!/bin/bash # Description: Verify consistency of ESP-IDF version across configuration files. # Test: Search for ESP-IDF version references. Expect: Only occurrences of version 5.1.4. rg --type-add 'yml:*.yml' --type yaml --type yml 'esp-idf' | rg 'v5\.1\.4'Length of output: 74
Script:
#!/bin/bash # Description: Verify consistency of ESP-IDF version across configuration files. # Test: Search for any ESP-IDF version references to ensure consistency. rg --type-add 'yml:*.yml' --type yaml --type yml 'esp-idf'Length of output: 1590
azure-pipelines.yml (2)
409-409
: Ensure consistency in revision countersThe revision counters for various platforms (STM32, ESP32, NXP, TI SimpleLink, Azure RTOS, WIN32) have been updated. It's important to ensure that these counters are consistent and correctly incremented to reflect the new version
1.10.0
.Also applies to: 559-559, 640-640, 718-718, 789-789, 840-840
51-51
: Update ESP-IDF version reference in main pipelineThe ESP-IDF version reference has been updated to
v5.1.4
in the main pipeline configuration. This update should be consistent with other pipeline configurations to ensure uniform version usage across the project.
Description
Motivation and Context
How Has This Been Tested?
Screenshots
Types of changes
Checklist
Summary by CodeRabbit