Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate IDF to v5.1.4 #2975

Merged
merged 1 commit into from
Jun 28, 2024
Merged

Migrate IDF to v5.1.4 #2975

merged 1 commit into from
Jun 28, 2024

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Jun 28, 2024

Description

  • Bump versions in dev containers.
  • Bump versions in revision counters for builds.
  • Update tag in ESP32 build components cache.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

Summary by CodeRabbit

  • Chores
    • Updated Dockerfiles for development containers to use the latest image versions.
    • Updated ESP-IDF repository versions in Dockerfiles and related scripts.
    • Updated version references across various pipelines and configuration files to ensure compatibility with the latest libraries and tools.

- Bump versions in dev containers.
- Bump versions in revision counters for builds.
- Update tag in ESP32 build components cache.
@nfbot nfbot added Area: Config-and-Build Area: Dev-Containers Type: dependencies Pull requests that update a dependency file(s) or version labels Jun 28, 2024
Copy link

coderabbitai bot commented Jun 28, 2024

Walkthrough

The updates primarily involve incrementing versions for Docker images, ESP-IDF repository tags, and version counters across multiple components like ESP32, STM32, TI SimpleLink, and Azure RTOS. These changes enhance consistency, maintain compatibility, and integrate new features or improvements in the updated versions.

Changes

File/Directory Change Summary
.devcontainer/All/Dockerfile.All, .devcontainer/ESP32/Dockerfile.ESP32 Updated Docker image versions for All to v2.47 and ESP32 to v2.31.
.devcontainer/All/Dockerfile.All.SRC, .devcontainer/ESP32/Dockerfile.ESP32.SRC Cloned ESP-IDF repository from version v5.1.3 to v5.1.4.
azure-pipelines-nightly.yml Updated esp-idf tag from v5.1.3 to v5.1.4 and version counters to 1_10_0.
azure-pipelines-templates/.../download-install-esp32-build-components.yml Updated cache key for ESP32 tools from v5.1.3 to v5.1.4.
azure-pipelines.yml Updated version counters to 1.10.0 for multiple platforms.
targets/ESP32/CMakeLists.txt Updated ESP32_IDF_TAG from 5.1.3 to 5.1.4.
version.json Updated version number from 1.9.1 to 1.10.0.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 9076eb7 and 31e3646.

Files selected for processing (9)
  • .devcontainer/All/Dockerfile.All (1 hunks)
  • .devcontainer/All/Dockerfile.All.SRC (1 hunks)
  • .devcontainer/ESP32/Dockerfile.ESP32 (1 hunks)
  • .devcontainer/ESP32/Dockerfile.ESP32.SRC (1 hunks)
  • azure-pipelines-nightly.yml (5 hunks)
  • azure-pipelines-templates/download-install-esp32-build-components.yml (1 hunks)
  • azure-pipelines.yml (7 hunks)
  • targets/ESP32/CMakeLists.txt (1 hunks)
  • version.json (2 hunks)
Files skipped from review due to trivial changes (6)
  • .devcontainer/All/Dockerfile.All
  • .devcontainer/All/Dockerfile.All.SRC
  • .devcontainer/ESP32/Dockerfile.ESP32
  • .devcontainer/ESP32/Dockerfile.ESP32.SRC
  • targets/ESP32/CMakeLists.txt
  • version.json
Additional context used
yamllint
azure-pipelines-templates/download-install-esp32-build-components.yml

[error] 1-1: wrong new line character: expected \n

(new-lines)

azure-pipelines-nightly.yml

[error] 1-1: wrong new line character: expected \n

(new-lines)


[error] 49-49: trailing spaces

(trailing-spaces)


[error] 57-57: trailing spaces

(trailing-spaces)


[error] 62-62: trailing spaces

(trailing-spaces)


[error] 102-102: trailing spaces

(trailing-spaces)


[error] 103-103: trailing spaces

(trailing-spaces)


[error] 104-104: trailing spaces

(trailing-spaces)


[error] 106-106: trailing spaces

(trailing-spaces)


[error] 118-118: trailing spaces

(trailing-spaces)


[error] 128-128: trailing spaces

(trailing-spaces)


[error] 139-139: trailing spaces

(trailing-spaces)


[error] 173-173: trailing spaces

(trailing-spaces)


[error] 178-178: trailing spaces

(trailing-spaces)


[error] 210-210: trailing spaces

(trailing-spaces)


[error] 229-229: trailing spaces

(trailing-spaces)


[error] 502-502: trailing spaces

(trailing-spaces)

azure-pipelines.yml

[error] 1-1: wrong new line character: expected \n

(new-lines)


[error] 39-39: trailing spaces

(trailing-spaces)


[error] 80-80: trailing spaces

(trailing-spaces)


[error] 94-94: trailing spaces

(trailing-spaces)


[error] 98-98: trailing spaces

(trailing-spaces)


[error] 132-132: trailing spaces

(trailing-spaces)


[error] 134-134: trailing spaces

(trailing-spaces)


[error] 140-140: trailing spaces

(trailing-spaces)


[error] 148-148: trailing spaces

(trailing-spaces)


[error] 156-156: trailing spaces

(trailing-spaces)


[error] 167-167: trailing spaces

(trailing-spaces)


[error] 168-168: trailing spaces

(trailing-spaces)


[error] 169-169: trailing spaces

(trailing-spaces)


[error] 170-170: trailing spaces

(trailing-spaces)


[error] 173-173: trailing spaces

(trailing-spaces)


[error] 174-174: trailing spaces

(trailing-spaces)


[error] 175-175: trailing spaces

(trailing-spaces)


[error] 177-177: trailing spaces

(trailing-spaces)


[error] 191-191: trailing spaces

(trailing-spaces)


[error] 235-235: trailing spaces

(trailing-spaces)


[error] 246-246: trailing spaces

(trailing-spaces)


[error] 247-247: trailing spaces

(trailing-spaces)


[error] 309-309: trailing spaces

(trailing-spaces)


[error] 315-315: trailing spaces

(trailing-spaces)


[error] 674-674: trailing spaces

(trailing-spaces)

Additional comments not posted (5)
azure-pipelines-templates/download-install-esp32-build-components.yml (1)

9-10: Update cache keys to version 5.1.4

The cache keys for ESP32 tools have been updated to reflect the new version 5.1.4. Ensure that these keys are unique across different builds to avoid potential cache collisions.

azure-pipelines-nightly.yml (2)

296-296: Update revision counters for different platforms

The revision counters for STM32, ESP32, TI SimpleLink, and Azure RTOS have been updated to be in sync with the new version 1.10.0. This is a crucial update to maintain the build versioning integrity.

Also applies to: 547-547, 623-623, 674-674


20-20: Update ESP-IDF version reference

The ESP-IDF version reference has been updated to v5.1.4. This change should be cross-verified with other configuration files to ensure consistency across the entire project.

Verification successful

Update ESP-IDF version reference

The ESP-IDF version reference has been updated to v5.1.4 in azure-pipelines-nightly.yml. The verification shows no inconsistencies in ESP-IDF version references across the configuration files.

  • azure-pipelines-nightly.yml: Line 20
Scripts executed

The following scripts were executed for the analysis:


Script:

#!/bin/bash
# Description: Verify consistency of ESP-IDF version across configuration files.

# Test: Search for ESP-IDF version references. Expect: Only occurrences of version 5.1.4.
rg --type yaml --type yml 'esp-idf' | rg 'v5\.1\.4'

Length of output: 79



Script:

#!/bin/bash
# Description: Verify consistency of ESP-IDF version across configuration files.

# Test: Search for ESP-IDF version references. Expect: Only occurrences of version 5.1.4.
rg --type-add 'yml:*.yml' --type yaml --type yml 'esp-idf' | rg 'v5\.1\.4'

Length of output: 74



Script:

#!/bin/bash
# Description: Verify consistency of ESP-IDF version across configuration files.

# Test: Search for any ESP-IDF version references to ensure consistency.
rg --type-add 'yml:*.yml' --type yaml --type yml 'esp-idf'

Length of output: 1590

azure-pipelines.yml (2)

409-409: Ensure consistency in revision counters

The revision counters for various platforms (STM32, ESP32, NXP, TI SimpleLink, Azure RTOS, WIN32) have been updated. It's important to ensure that these counters are consistent and correctly incremented to reflect the new version 1.10.0.

Also applies to: 559-559, 640-640, 718-718, 789-789, 840-840


51-51: Update ESP-IDF version reference in main pipeline

The ESP-IDF version reference has been updated to v5.1.4 in the main pipeline configuration. This update should be consistent with other pipeline configurations to ensure uniform version usage across the project.

@josesimoes josesimoes merged commit 5f5feb1 into nanoframework:main Jun 28, 2024
38 checks passed
@josesimoes josesimoes deleted the move-idf-5_1_4 branch June 28, 2024 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Config-and-Build Area: Dev-Containers Type: dependencies Pull requests that update a dependency file(s) or version
Projects
None yet
2 participants