Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed_Time hardening model: should error for (1) times out of bounds, (2) incorrect interpolation #43

Open
lzkelley opened this issue Feb 19, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@lzkelley
Copy link
Member

When requesting hardening timescales of 1e-5 and 1e5 Gyr (for example), the resulting interpolated values completely fail to reproduce these timescales and the resulting GWB spectrum is identical.

(1) The code should raise an error for values outside of bounds
(2) The code should raise an error if the resulting interpolated values deviate from the desired hardening timescales by greater than some factor. (Note: currently a warning is raised that the 'normal' interpolant failed, and the 'backup' is being used). Accuracy should be checked for both interpolants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant