Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I have fully rewritten this library, using same concepts, can we add an reference to the readme for other users? #399

Open
vitalyiegorov opened this issue Jul 26, 2023 · 6 comments

Comments

@vitalyiegorov
Copy link

vitalyiegorov commented Jul 26, 2023

Hello @barbieri @miracle2k @markrickert @madoke @kowalski

Thank you guys for this awesome library, as this is the only react-native library for processing the ApplePay/GooglePay,
unfortunately this library is not maintained anymore and not working on the Android(for us),

We have started with the fork by merging existing PRs, but unfortunately
it did not work without additional native code changes, so I have decided to rewrite the lib using latest Android/Apple/W3C docs:

@rnw-community/react-native-payments

Would be nice to provide a link in the readme for other users.

Any feedback and PRs are highly appreciated.

@barbieri
Copy link
Contributor

Hi, thanks for sharing. I'm not using this lib in any projects at this moment, but let's hope someone takes the maintenance 🙏

@vurtnec
Copy link

vurtnec commented Nov 3, 2023

@vitalyiegorov , thanks! your library help us a lot!!

@vitalyiegorov
Copy link
Author

@vurtnec Would be nice if you could open an issue or PR with the description of successful usage and gateway that you are using?

@vurtnec
Copy link

vurtnec commented Nov 3, 2023

@vitalyiegorov , I'm still working on Fiserv integration with your SDK, still have some issue but looks like not related to the SDK. Will sync it once done.

@vurtnec
Copy link

vurtnec commented Nov 3, 2023

@vitalyiegorov By the way, do you know why publicKeyHash is valid when send payload to gateway?

@wachunei
Copy link

wachunei commented Dec 14, 2023

@vitalyiegorov Hi! I'm taking a look at your rewrite and it is looking promising! Do you have a quick list of things that have changed from this package?, for example on iOS paymentRequest.merchantCapabilities can now be set, but also does not default to PKMerchantCapability3DS anymore, these kind of this. Great job!

update: I just saw you do on the js side https://github.com/rnw-community/rnw-community/blob/master/packages/react-native-payments/src/class/payment-request/payment-request.ts#L242C24-L242C24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants