Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible typo in iosdriver? #1143

Closed
1 task done
ghost opened this issue Mar 10, 2020 · 1 comment · Fixed by #1174
Closed
1 task done

possible typo in iosdriver? #1143

ghost opened this issue Mar 10, 2020 · 1 comment · Fixed by #1174
Milestone

Comments

@ghost
Copy link

ghost commented Mar 10, 2020

Description of Issue/Question

Hi,

while i'm playing with my driver fork ... it's probably nothing, but it doesn't make much sense to me. See the if ttl block.

regards

ios.py:L3196 [traceroute()]

        if ttl:
           if isinstance(ttl, int) and 0 <= timeout <= 255:
               command += " ttl 0 {}".format(str(ttl))
        if timeout:
            # Timeout should be an integer between 1 and 3600
            if isinstance(timeout, int) and 1 <= timeout <= 3600:
                command += " timeout {}".format(str(timeout))

Did you follow the steps from https://github.com/napalm-automation/napalm#faq

(Place an x between the square brackets where applicable)

  • Yes
  • [] No

Setup

napalm version

(Paste verbatim output from pip freeze | grep napalm between quotes below)

current develop branch(c35d503)

Network operating system version

(Paste verbatim output from show version - or equivalent - between quotes below)

n/a

Steps to Reproduce the Issue

n/a

Error Traceback

(Paste the complete traceback of the exception between quotes below)

n/a
@mirceaulinic
Copy link
Member

Yes, I think that looks a bit 🐟 - at least the command += " ttl 0 {}".format(str(ttl)) which should probably be command += " ttl {}".format(ttl) instead. Feel free to open a PR for that @remingu.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant