Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove sub-sub section heading from rendering guide #236

Merged
merged 2 commits into from
Sep 14, 2023

Conversation

dstansby
Copy link
Contributor

@dstansby dstansby commented Sep 1, 2023

Description

The block of text under this heading doesn't refer to time-series data. While it's applicable to time-series data, it's also applicable to 3D volume data, so it seemed easiest just to remove the heading.

Type of change

  • Fixes or improves existing content

References

Final checklist:

  • My PR is the minimum possible work for the desired functionality
  • I have commented my code, particularly in hard-to-understand areas
  • I have added alt text to new images included in this PR

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 1, 2023
Copy link
Member

@psobolewskiPhD psobolewskiPhD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huh, that heading is kinda oddly out of place isn't it.
Thanks for catching this.

Small aside--not blocking, just came to mind: @andy-sweet do we need to update any of this for the new async? If so, should we make an issue to track?

@psobolewskiPhD psobolewskiPhD added this to the 0.4.19 milestone Sep 14, 2023
@psobolewskiPhD psobolewskiPhD merged commit e45e6b7 into napari:main Sep 14, 2023
3 checks passed
@dstansby dstansby deleted the odd-title branch September 14, 2023 07:49
@andy-sweet
Copy link
Member

Small aside--not blocking, just came to mind: @andy-sweet do we need to update any of this for the new async? If so, should we make an issue to track?

Yes, you're right. I added an issue to describe some thoughts and ideas there: #237

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants