Skip to content
This repository has been archived by the owner on Sep 8, 2020. It is now read-only.

Fail CircleCI builds when "automated" fields in manifest.json are changed #23

Open
nareddyt opened this issue Mar 13, 2018 · 0 comments
Labels
bug Something isn't working good first issue Good for beginners

Comments

@nareddyt
Copy link
Owner

Some fields in manifest.json are "automated", meaning they are actually set by CircleCI during Continuous Deployment. Those fields should never manually be changed by developers, as CircleCI will always set them to the correct value.

List of "automated" fields in manifest.json:

  • version
  • version_name
  • icons

Perhaps we should make a bash script to ensure these fields are set to their defaults. Then, we can run this inside the CircleCI build step, failing the build if a developer changes these "automated" fields.

@nareddyt nareddyt added bug Something isn't working good first issue Good for beginners labels Mar 13, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for beginners
Projects
None yet
Development

No branches or pull requests

1 participant