create synonym group for eventId if none exists #2642
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
========================================
- Coverage 6.22% 6.22% -0.01%
========================================
Files 167 167
Lines 4222 4242 +20
Branches 466 469 +3
========================================
+ Hits 263 264 +1
- Misses 3957 3976 +19
Partials 2 2 ☔ View full report in Codecov by Sentry. |
|
Why is this necessary? Is it because, currently, the grouped view does not show events that do not have an entry in the synonyms table? |
yup. Judy wanted to all events to have an entry, not just the manually created ones. |
|
And in addition to this change, I am aware that there needs to be a backfill to get things to work. I need a backfill to populate the eventId in circulars that existed before I added in the eventId on circular creation. I then need a backfill to populate the synonyms with the existing eventIds. |
|
This code contains a race condition. |
|
okay. I'll not make draft PRs for things I'm still working on in the future. This is not ready for review at all. |
I wouldn't say that! Anyone is always welcome to make draft PRs.
I wasn't offering a review; I was just asking for the motivation for this PR, since I missed the Monday call. |
Courey
requested review from
lpsinger and
dakota002
and removed request for
lpsinger
There was a problem hiding this comment.
Please use TransactWriteItems to eliminate the race condition.
Description
This change adds functionality to check if there is an existing synonym group for an eventId upon circular creation. If there is an eventId and no synonym group for that eventId, it creates one. If there is no eventId it skips. If there is an eventId and the synonym group already exists for that eventId it skips.
Related Issue(s)
Resolves #2661
Testing
I tested this locally.
However, because it is in a critical area, we need to thoroughly test it on dev.