Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #105, Remove 'dummy' from variable names #367

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution
Fixes #105
Removed (unnecessary) use of 'dummy' in several variable names.
Note there are several other issues open to clean up the unit tests in CF, including improving/shortening the test function names.

Testing performed
GitHub CI actions (incl. Build + Run, Unit Tests etc.) all passing successfully.

Expected behavior changes
None

Contributor Info
Avi Weiss @thnkslprpt

@dzbaker
Copy link
Contributor

dzbaker commented Mar 9, 2023

Hey @thnkslprpt, would you be able to resolve the conflicts? Thanks!

@thnkslprpt thnkslprpt force-pushed the fix-105-remove-dummy-from-variable-names branch 3 times, most recently from 4ef9460 to c23dcd5 Compare March 10, 2023 00:14
@thnkslprpt thnkslprpt closed this Mar 10, 2023
@thnkslprpt thnkslprpt force-pushed the fix-105-remove-dummy-from-variable-names branch from c23dcd5 to c44e372 Compare March 10, 2023 00:17
@thnkslprpt
Copy link
Contributor Author

Tied myself in a few knots and somehow closed this PR.
I know it's possible to re-open this PR, but thought it might be simpler to re-submit as a single commit without the merge conflicts etc.
#370
Apologies for the re-assessment...

@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove use of "dummy" in variable names
6 participants