Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #76, Move function prototypes out of cs_app.c #77

Merged

Conversation

thnkslprpt
Copy link
Contributor

@thnkslprpt thnkslprpt commented Apr 5, 2023

Checklist

Describe the contribution

Moving them to the header file also means they don't need to be separately declared in the test files:

int32 CS_AppInit(void);
int32 CS_AppPipe(CFE_SB_Buffer_t *BufPtr);
void CS_HousekeepingCmd(const CS_NoArgsCmd_t *CmdPtr);
int32 CS_CreateRestoreStatesFromCDS(void);
void CS_App_TestCmdTlmAlign(void)

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No change to app behavior.
CS now more consistent with the other cFS apps.

Contributor Info
Avi Weiss @thnkslprpt

@github-advanced-security
Copy link

You have successfully added a new CppCheck configuration cppcheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration security. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@github-advanced-security
Copy link

You have successfully added a new CodeQL configuration coding-standard. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Functional behavior is preserved.

@dzbaker
Copy link
Contributor

dzbaker commented Apr 13, 2023

@thnkslprpt Would you be able to resolve the conflict?

@thnkslprpt thnkslprpt force-pushed the fix-76-move-function-prototypes-out-of-cs-app branch from a530535 to 3ce83f7 Compare April 13, 2023 21:01
@thnkslprpt thnkslprpt force-pushed the fix-76-move-function-prototypes-out-of-cs-app branch from 3ce83f7 to a69c7d7 Compare April 13, 2023 21:03
@dzbaker dzbaker merged commit f94e37d into nasa:main Apr 13, 2023
@thnkslprpt thnkslprpt deleted the fix-76-move-function-prototypes-out-of-cs-app branch April 13, 2023 21:16
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function prototypes can be moved out of cs_app.c
4 participants