Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #78, Convert int32 return codes and variables to CFE_Status_t #79

Merged

Conversation

thnkslprpt
Copy link
Contributor

Checklist

Describe the contribution

  • Fixes CS int32 return codes and variables should be converted to CFE_Status_t #78
    • int32 return codes converted over to CFE_Status_t (incl. in the test code)
    • int32 status/return variables holding cFE return codes converted to CFE_Status_t (incl. in the test code)
    • removed the CS_SUCCESS macro (and replaced with CFE_SUCCESS) which was in the "error codes" section (there were only a few uses anyway). It seems clearer to just use CFE_SUCCESS for all success returns in the app and from calls to CFE etc.
    • removed some trailing whitespace from the yaml files to avoid any future warnings

Does CS_SUCCESS need to be deprecated even though it's equivelent to CFE_SUCCESS, i.e. == 0)?

Testing performed
GitHub CI actions all passing successfully.

Expected behavior changes
No change to behavior (no types have actually changed with this PR).
CFE_Status_t is more expressive and improves consistency with cFE/cFS.

Contributor Info
Avi Weiss @thnkslprpt

Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CodeQL found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@dzbaker dzbaker requested a review from chillfig April 13, 2023 18:56
@thnkslprpt thnkslprpt force-pushed the fix-78-convert-return-codes-to-CFE_Status_t branch from 3d8d4ab to cdbaf98 Compare April 17, 2023 21:11
@thnkslprpt thnkslprpt force-pushed the fix-78-convert-return-codes-to-CFE_Status_t branch from cdbaf98 to 6fbb416 Compare April 17, 2023 23:14
Copy link
Contributor

@chillfig chillfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good!

@dzbaker dzbaker merged commit 579979b into nasa:main Apr 20, 2023
@thnkslprpt thnkslprpt deleted the fix-78-convert-return-codes-to-CFE_Status_t branch April 20, 2023 21:07
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CS int32 return codes and variables should be converted to CFE_Status_t
4 participants