Fix #78, Convert int32
return codes and variables to CFE_Status_t
#79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Describe the contribution
int32
return codes and variables should be converted toCFE_Status_t
#78int32
return codes converted over toCFE_Status_t
(incl. in the test code)int32
status
/return
variables holding cFE return codes converted toCFE_Status_t
(incl. in the test code)CS_SUCCESS
macro (and replaced withCFE_SUCCESS)
which was in the "error codes" section (there were only a few uses anyway). It seems clearer to just useCFE_SUCCESS
for all success returns in the app and from calls to CFE etc.Does
CS_SUCCESS
need to be deprecated even though it's equivelent toCFE_SUCCESS,
i.e.== 0
)?Testing performed
GitHub CI actions all passing successfully.
Expected behavior changes
No change to behavior (no types have actually changed with this PR).
CFE_Status_t
is more expressive and improves consistency with cFE/cFS.Contributor Info
Avi Weiss @thnkslprpt