-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #17, update code coverage for fm_cmd_utils.c #33
Conversation
@havencarlson this needs a run through clang format to fix white space. You can also fix it manually by looking at the output of the format check workflow |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comments apply to patterns throughout the change. Avoid UtAssert_True, UT_GetStubCount, etc in favor of the macros that standardize the report information. Ensure variables are initialized before use, etc.
7f52693
to
13062f1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Just a few minor updates recommended. Happy to chat if it helps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, great work!
@astrogeco - should be ready to merge... we'll need to update the workflow allowed missed branches/lines once these are all in. |
@chillfig Still need some format fixes |
CCB:2022-06-15 APPROVED |
Checklist (Please check before submitting)
Describe the contribution
Updated unit tests for fm_cmd_utils.c to cover LoadOpenFileData, SearchOpenFileData, and branches.
Testing performed
Steps taken to test the contribution:
Expected behavior changes
no impact to behavior
System(s) tested on
Additional context
Add any other context about the contribution here.
Third party code
If included, identify any third party code and provide text file of license
Contributor Info - All information REQUIRED for consideration of pull request
Full name and company/organization/center of all contributors ("Personal" if individual work)