-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #50, Apply consistent Event ID names to common events #51
Fix #50, Apply consistent Event ID names to common events #51
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
HS_RESET_INF_EID
and/or comments mentioning it may need an update before merging. Comments suggest it is of DEBUG type.
fsw/src/hs_events.h
Outdated
@@ -320,7 +320,7 @@ | |||
* This event message is issued when a reset counters command has | |||
* been received. | |||
*/ | |||
#define HS_RESET_DBG_EID 24 | |||
#define HS_RESET_INF_EID 24 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does the event name change from DBG to INF? Shouldn't line 316 also change to indicate Informational type?
This line may also need an update if the change is warranted.
https://github.com/thnkslprpt/HS/blob/e90051e221c462b8cf0409253a677e0df8459947/fsw/src/hs_msgdefs.h#L113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah it's really a matter of interpretation whether to list some of these as DBG or INF.
I will update the comments to align with the common Event ID type as per the updates.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be updated now mate.
e90051e
to
e8bb8ac
Compare
e8bb8ac
to
3d39202
Compare
fsw/src/hs_msgdefs.h
Outdated
@@ -110,7 +110,7 @@ | |||
* Successful execution of this command may be verified with | |||
* the following telemetry: | |||
* - #HS_HkPacket_t.CmdCount will be cleared | |||
* - The #HS_RESET_DBG_EID debug event message will be | |||
* - The #HS_RESET_INF_EID debug event message will be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* - The #HS_RESET_INF_EID debug event message will be | |
* - The #HS_RESET_INF_EID informational event message will be |
3d39202
to
0652ca2
Compare
0652ca2
to
051741b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look consistent to me.
0a7a50d
to
05a5cf1
Compare
05a5cf1
to
98da814
Compare
98da814
to
5fb454f
Compare
5fb454f
to
36b5b19
Compare
Checklist
Describe the contribution
Testing performed
Only GitHub CI actions.
Expected behavior changes
No impact on code behavior (no logic changes).
Consistent Event ID names for the events which are common to all/most cFS components and apps will improve consistency and ease make code review/debugging easier.
Contributor Info
Avi Weiss @thnkslprpt