Fix #75, Moved command validation out of command functions #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fsw/src/mm_dump.c
Outdated
| } /* end MM_WriteFileHeaders if */ | ||
|
|
||
| /* Close dump file */ | ||
| if ((OS_Status = OS_close(FileHandle)) != OS_SUCCESS) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
fsw/src/mm_load.c
Outdated
| /* Verify command packet length */ | ||
| if (MM_VerifyCmdLength(&BufPtr->Msg, ExpectedLength)) | ||
| /* Resolve symbolic address */ | ||
| if (MM_ResolveSymAddr(&(DestSymAddress), &DestAddress) == true) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
fsw/src/mm_load.c
Outdated
| /* Resolve the symbolic address in command message */ | ||
| if (MM_ResolveSymAddr(&(DestSymAddress), &DestAddress) == true) | ||
| /* Resolve the symbolic address in command message */ | ||
| if (MM_ResolveSymAddr(&(DestSymAddress), &DestAddress) == true) |
Check warning
Code scanning / CodeQL
Side effect in a Boolean expression
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fixes #75 , validate command before calling the command function instead of after.
Testing performed
Unit testing
Expected behavior changes
no impact to behavior
System(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA